All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Adrian Bunk <bunk@stusta.de>,
	akpm@osdl.org, cotte@de.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 3/17] s390: move s390_root_dev_* out of the cio layer.
Date: Fri, 9 Dec 2005 23:50:16 -0800	[thread overview]
Message-ID: <20051210075016.GA21423@kroah.com> (raw)
In-Reply-To: <1134147283.5576.1.camel@localhost.localdomain>

On Fri, Dec 09, 2005 at 05:54:43PM +0100, Martin Schwidefsky wrote:
> On Fri, 2005-12-09 at 17:51 +0100, Adrian Bunk wrote:
> > On Fri, Dec 09, 2005 at 04:23:45PM +0100, Martin Schwidefsky wrote:
> > > +extern struct device *s390_root_dev_register(const char *);
> > > +extern void s390_root_dev_unregister(struct device *);
> > >...
> > 
> > If you do _really_ need these wrappers, simply make them
> > "static inline"'s in the header file.
> 
> We can't. The point here is that we need an external release function
> that is still available after the module has been unloaded that uses
> these wrappers.

release is find and understandable.  But the unregister one is just
pretty foolish :)

thanks,

greg k-h

  reply	other threads:[~2005-12-10  7:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-09 15:23 [patch 3/17] s390: move s390_root_dev_* out of the cio layer Martin Schwidefsky
2005-12-09 16:51 ` Adrian Bunk
2005-12-09 16:54   ` Martin Schwidefsky
2005-12-10  7:50     ` Greg KH [this message]
2005-12-12  9:36       ` Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051210075016.GA21423@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=cotte@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.