From: Pavel Machek <pavel@ucw.cz>
To: Jordan Crouse <jordan.crouse@amd.com>
Cc: gardner.ben@gmail.com, linux-kernel@vger.kernel.org,
info-linux@ldcmail.amd.com
Subject: Re: [PATCH 1/3] i386: CS5535 chip support - cpu
Date: Sat, 10 Dec 2005 08:44:22 +0000 [thread overview]
Message-ID: <20051210084422.GC2833@ucw.cz> (raw)
In-Reply-To: <20051207194226.GA2617@cosmic.amd.com>
On Wed 07-12-05 12:42:26, Jordan Crouse wrote:
> +/* Note - this does not check to see if the CS5535 actually exists */
> +
> +#define LO(b) (((1 << b) << 16) | 0x0000)
> +#define HI(b) ((0x0000 << 16) | (1 << b))
> +
What kind of ninja mutant macros are these?
> +static u32 intab[16] __initdata = {
> + 0x20,HI(3), 0x24,LO(3), 0x28,LO(3),
> + 0x2C,LO(3), 0x34,HI(3), 0x38,LO(3),
> + 0x40,LO(3), 0x44,LO(3)
> +};
Can't you just use values here, without the macros?
Pavel
--
Thanks, Sharp!
next prev parent reply other threads:[~2005-12-10 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 19:42 [PATCH 1/3] i386: CS5535 chip support - cpu Jordan Crouse
2005-12-09 15:01 ` Ben Gardner
2005-12-09 22:47 ` Jordan Crouse
2005-12-10 8:44 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-12-07 17:31 [PATCH 1/3] " Ben Gardner
2005-12-07 18:12 ` Adrian Bunk
2005-12-07 19:31 ` Ben Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051210084422.GC2833@ucw.cz \
--to=pavel@ucw.cz \
--cc=gardner.ben@gmail.com \
--cc=info-linux@ldcmail.amd.com \
--cc=jordan.crouse@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.