All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Greg KH <greg@kroah.com>, LKML <linux-kernel@vger.kernel.org>,
	Russell King <rmk+lkml@arm.linux.org.uk>
Subject: Re: [patch 1/2] Add platform_device_del()
Date: Sat, 10 Dec 2005 17:58:16 +0100	[thread overview]
Message-ID: <20051210175816.6ce682df.khali@linux-fr.org> (raw)
In-Reply-To: <20051210064750.775640000.dtor_core@ameritech.net>

Hi Dmirty,

> Driver core: add platform_device_del function
> 
> Having platform_device_del90 allows more straightforward error
> handling code in drivers registering platform devices.
> (...)
> +/**
> + *	platform_device_unregister - unregister a platform-level device
> + *	@pdev:	platform device we're unregistering
> + *
> + *	Unregistration is done in 2 steps. Fisrt we release all resources
> + *	and remove it from the sybsystem, then we drop reference count by

Typo: subsystem.

> + *	calling platform_device_put().
> + */

Other than that, and let alone the fact that I prefer code cleanups as
separate patches, and the fact that I don't think moving
platform_device_register() around adds much value, this patch looks
good to me.

Thanks,
-- 
Jean Delvare

  reply	other threads:[~2005-12-10 16:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-10  6:36 [patch 0/2] Add platform_device_del() Dmitry Torokhov
2005-12-10  6:36 ` [patch 1/2] " Dmitry Torokhov
2005-12-10 16:58   ` Jean Delvare [this message]
2005-12-10 17:47     ` Dmitry Torokhov
2005-12-10  6:36 ` [patch 2/2] Rearrange exports in platform.c Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051210175816.6ce682df.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=dtor_core@ameritech.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.