From: Tony Breeds <tony@bakeyournoodle.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Xen-Devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 3/3] Some "make check" tests for xen/common
Date: Sun, 11 Dec 2005 10:15:00 +1100 [thread overview]
Message-ID: <20051210231500.GA25348@bakeyournoodle.com> (raw)
In-Reply-To: <4399A84A.4010104@us.ibm.com>
On Fri, Dec 09, 2005 at 09:52:42AM -0600, Anthony Liguori wrote:
> Hi Tony,
Hi Anthony,
> I've been trying out the make check/fullcheck and I'm very impressed! I
> hope it gets pulled into the tree soon.
>
> Two suggestions though, for patches this large, it would help to either
> attach it to the original mail or provide a url to it. inlining is nice
> for review but a pain to pull out and apply to a tree.
Will do for next time.
> Also, with the latest unstable (8311:53cff3f88e45) the patches fail to
> build (on xen/common/test/test_event_channel.c) because it cannot find
> the include file <public/event_channel.h> in the #include
> "../event_channel.c". I was able to work around this by adding
> -I../../include to the build rule in the Makefile.
Thanks for the feedback.
There was a typo in patch 1/3. It created public/event_chnnel.h instead
of public/event_channel.h.
Sorry.
The patch below can be applied on top of the other 3 to build a working
test.
--- xen-unstable.hg/xen/test/Makefile~ 2005-12-11 10:05:58.000000000 +1100
+++ xen-unstable.hg/xen/test/Makefile 2005-12-11 10:06:01.000000000 +1100
@@ -1,4 +1,4 @@
-LINKS:=asm/types.h asm/uaccess.h asm/system.h asm/desc.h xen/config.h xen/types.h xen/errno.h xen/bitmap.h xen/bitops.h xen/lib.h xen/spinlock.h xen/time.h xen/string.h xen/init.h xen/sched.h xen/smp.h xen/perfc.h xen/softirq.h xen/ac_timer.h xen/keyhandler.h xen/mm.h public/acm.h public/acm_ops.h xen/event.h xen/trace.h xen/console.h asm/shadow.h public/sched_ctl.h acm/acm_hooks.h xen/domain.h xen/domain_page.h asm/debugger.h public/dom0_ops.h public/sched.h public/vcpu.h xen/irq.h asm/current.h public/xen.h public/event_chnnel.h
+LINKS:=asm/types.h asm/uaccess.h asm/system.h asm/desc.h xen/config.h xen/types.h xen/errno.h xen/bitmap.h xen/bitops.h xen/lib.h xen/spinlock.h xen/time.h xen/string.h xen/init.h xen/sched.h xen/smp.h xen/perfc.h xen/softirq.h xen/ac_timer.h xen/keyhandler.h xen/mm.h public/acm.h public/acm_ops.h xen/event.h xen/trace.h xen/console.h asm/shadow.h public/sched_ctl.h acm/acm_hooks.h xen/domain.h xen/domain_page.h asm/debugger.h public/dom0_ops.h public/sched.h public/vcpu.h xen/irq.h asm/current.h public/xen.h public/event_channel.h
clean:
Yours Tony
linux.conf.au http://linux.conf.au/ || http://lca2006.linux.org.au/
Jan 23-28 2006 The Australian Linux Technical Conference!
prev parent reply other threads:[~2005-12-10 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-09 5:56 [PATCH 3/3] Some "make check" tests for xen/common Tony Breeds
2005-12-09 15:52 ` Anthony Liguori
2005-12-10 23:15 ` Tony Breeds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051210231500.GA25348@bakeyournoodle.com \
--to=tony@bakeyournoodle.com \
--cc=aliguori@us.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.