From: Matthew Wilcox <matthew@wil.cx>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, ak@muc.de,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [patch 2/4] i386/x86-64: Implement fallback for PCI mmconfig to type1
Date: Mon, 12 Dec 2005 13:26:43 -0700 [thread overview]
Message-ID: <20051212202643.GG9286@parisc-linux.org> (raw)
In-Reply-To: <20051212200123.GC27657@kroah.com>
On Mon, Dec 12, 2005 at 12:01:23PM -0800, Greg Kroah-Hartman wrote:
> When there is no entry for a bus in MCFG fall back to type1. This is
> especially important on K8 systems where always some devices can't be
> accessed using mmconfig (in particular the builtin northbridge doesn't
> support it for its own devices)
[...]
> -static int pci_conf1_read(unsigned int seg, unsigned int bus,
> +int pci_conf1_read(unsigned int seg, unsigned int bus,
I don't like this at all. We already have a mechanism to use different
accessors per-bus (bus->ops->read()); calling the type1 accessors from
the mmconfig accessors just seems wrong.
> + if (!base)
> + return pci_conf1_read(seg,bus,devfn,reg,len,value);
Should be space after commas.
next prev parent reply other threads:[~2005-12-12 20:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20051212192030.873030000@press.kroah.org>
2005-12-12 20:00 ` [patch 0/4] Small fixes for 2.6.15-rc5 Greg Kroah-Hartman
2005-12-12 20:01 ` [lm-sensors] [patch 1/4] i2c: Fix i2c-mv64xxx compilation error Greg Kroah-Hartman
2005-12-12 20:01 ` Greg Kroah-Hartman
2005-12-12 20:01 ` [patch 2/4] i386/x86-64: Implement fallback for PCI mmconfig to type1 Greg Kroah-Hartman
2005-12-12 20:26 ` Matthew Wilcox [this message]
2005-12-12 21:15 ` Greg KH
2005-12-13 5:02 ` Andi Kleen
2005-12-12 20:01 ` [patch 3/4] x86_64/i386: Correct for broken MCFG tables on K8 systems Greg Kroah-Hartman
2005-12-12 20:01 ` [patch 4/4] UHCI: add missing memory barriers Greg Kroah-Hartman
2005-12-13 0:27 ` Jeff Garzik
2005-12-13 3:03 ` Greg KH
2005-12-13 3:32 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051212202643.GG9286@parisc-linux.org \
--to=matthew@wil.cx \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.