All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: [2.6 patch] kernel/params.c: fix sysfs access with CONFIG_MODULES=n
Date: Tue, 13 Dec 2005 02:50:54 +0100	[thread overview]
Message-ID: <20051213015053.GU23349@stusta.de> (raw)

From: Jason Wessel <jason.wessel@windriver.com>

All the work was done to setup the file and maintain the file handles but
the access functions were zeroed out due to the #ifdef.  Removing the
#ifdef allows full access to all the parameters when CONFIG_MODULES=n.

akpm: put it back again, but use CONFIG_SYSFS instead.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- 

This patch is 
fix-sysfs-access-to-module-parameters-with-config_modules\=n.patch
in -mm.

This patch is simple enough for getting it into 2.6.15 and I'm inclined 
to even submit it for -stable.

 kernel/params.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN kernel/params.c~fix-sysfs-access-to-module-parameters-with-config_modules=n kernel/params.c
--- devel/kernel/params.c~fix-sysfs-access-to-module-parameters-with-config_modules=n	2005-11-14 23:20:34.000000000 -0800
+++ devel-akpm/kernel/params.c	2005-11-14 23:20:51.000000000 -0800
@@ -619,7 +619,7 @@ static void __init param_sysfs_builtin(v
 
 
 /* module-related sysfs stuff */
-#ifdef CONFIG_MODULES
+#ifdef CONFIG_SYSFS
 
 #define to_module_attr(n) container_of(n, struct module_attribute, attr);
 #define to_module_kobject(n) container_of(n, struct module_kobject, kobj);
_

             reply	other threads:[~2005-12-13  1:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-13  1:50 Adrian Bunk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-12-20 14:21 [2.6 patch] kernel/params.c: fix sysfs access with CONFIG_MODULES=n Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051213015053.GU23349@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.