From: Stephen Hemminger <shemminger@osdl.org>
To: Olaf Hering <olh@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] skge: get rid of warning on race
Date: Tue, 13 Dec 2005 07:45:32 -0800 [thread overview]
Message-ID: <20051213074532.18ee734c@localhost.localdomain> (raw)
In-Reply-To: <20051213145054.GA24897@suse.de>
On Tue, 13 Dec 2005 15:50:54 +0100
Olaf Hering <olh@suse.de> wrote:
> On Mon, Dec 12, Linux Kernel Mailing List wrote:
>
> > tree 987cfbd2134b82bea55c55fa17bd70d29df70458
> > parent 0e670506668a43e1355b8f10c33d081a676bd521
> > author Stephen Hemminger <shemminger@osdl.org> Wed, 07 Dec 2005 07:01:49 -0800
> > committer Jeff Garzik <jgarzik@pobox.com> Tue, 13 Dec 2005 09:33:03 -0500
> >
> > [PATCH] skge: get rid of warning on race
>
> > drivers/net/skge.c | 10 ++++++----
>
> > - netif_stop_queue(dev);
> > - spin_unlock_irqrestore(&skge->tx_lock, flags);
> > + if (!netif_stopped(dev)) {
> > + netif_stop_queue(dev);
>
> Current Linus tree does not compile:
>
> drivers/net/skge.c:2283: error: implicit declaration of function 'netif_stopped'
Should have been netif_queue_stopped..
Index: skge-2.6/drivers/net/skge.c
===================================================================
--- skge-2.6.orig/drivers/net/skge.c
+++ skge-2.6/drivers/net/skge.c
@@ -2280,7 +2280,7 @@ static int skge_xmit_frame(struct sk_buf
}
if (unlikely(skge->tx_avail < skb_shinfo(skb)->nr_frags +1)) {
- if (!netif_stopped(dev)) {
+ if (!netif_queue_stopped(dev)) {
netif_stop_queue(dev);
printk(KERN_WARNING PFX "%s: ring full when
queue awake!\n",
next prev parent reply other threads:[~2005-12-13 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200512130559.jBD5xUjf015319@hera.kernel.org>
2005-12-13 14:50 ` [PATCH] skge: get rid of warning on race Olaf Hering
2005-12-13 15:45 ` Stephen Hemminger [this message]
2005-12-14 5:37 ` Dave Jones
2005-12-14 6:47 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051213074532.18ee734c@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.