From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Date: Tue, 13 Dec 2005 18:51:50 +0000 Subject: Re: [2.6 patch] don't allow users to set CONFIG_BROKEN=y Message-Id: <20051213185150.GP23349@stusta.de> List-Id: References: <20051211185212.GQ23349@stusta.de> <20051211192109.GA22537@flint.arm.linux.org.uk> <20051211193118.GR23349@stusta.de> <20051211194437.GB22537@flint.arm.linux.org.uk> <20051213001028.GS23349@stusta.de> <439ECDCC.80707@hogyros.de> <20051213140001.GG23349@stusta.de> <20051213173112.GA24094@flint.arm.linux.org.uk> <20051213180551.GN23349@stusta.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Simon Richter , Linux Kernel Development , tony.luck@intel.com, linux-ia64@vger.kernel.org, matthew@wil.cx, grundler@parisc-linux.org, parisc-linux@parisc-linux.org, Paul Mackerras , Linux/PPC Development , lethal@linux-sh.org, kkojima@rr.iij4u.or.jp, dwmw2@infradead.org, linux-mtd@lists.infradead.org On Tue, Dec 13, 2005 at 07:28:41PM +0100, Geert Uytterhoeven wrote: > On Tue, 13 Dec 2005, Adrian Bunk wrote: > > Do not allow people to create configurations with CONFIG_BROKEN=y. > > > > The sole reason for CONFIG_BROKEN=y would be if you are working on > > fixing a broken driver, but in this case editing the Kconfig file is > > trivial. > > > > Never ever should a user enable CONFIG_BROKEN. > ^^^^ > OK, a user, not an expert. Let's assume users don't enable EXPERIMENTAL. Let's assume users don't have any hardware (e.g. several SATA drivers) that requires EXPERIMENTAL... > But I'd like to at least have the possibility to enable broken drivers, even if > it's just for compile regression tests. If a kernel developer really wants to enable BROKEN drivers, my patch still gives them the possibility to do so with a trivial edit of init/Kconfig. > Gr{oetje,eeting}s, > > Geert cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from emailhub.stusta.mhn.de ([141.84.69.5] helo=mailout.stusta.mhn.de) by canuck.infradead.org with smtp (Exim 4.54 #1 (Red Hat Linux)) id 1EmFFe-0007Du-CL for linux-mtd@lists.infradead.org; Tue, 13 Dec 2005 13:51:55 -0500 Date: Tue, 13 Dec 2005 19:51:50 +0100 From: Adrian Bunk To: Geert Uytterhoeven Message-ID: <20051213185150.GP23349@stusta.de> References: <20051211185212.GQ23349@stusta.de> <20051211192109.GA22537@flint.arm.linux.org.uk> <20051211193118.GR23349@stusta.de> <20051211194437.GB22537@flint.arm.linux.org.uk> <20051213001028.GS23349@stusta.de> <439ECDCC.80707@hogyros.de> <20051213140001.GG23349@stusta.de> <20051213173112.GA24094@flint.arm.linux.org.uk> <20051213180551.GN23349@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: tony.luck@intel.com, linux-ia64@vger.kernel.org, grundler@parisc-linux.org, matthew@wil.cx, Linux Kernel Development , Linux/PPC Development , lethal@linux-sh.org, Paul Mackerras , linux-mtd@lists.infradead.org, Simon Richter , dwmw2@infradead.org, kkojima@rr.iij4u.or.jp, parisc-linux@parisc-linux.org Subject: Re: [2.6 patch] don't allow users to set CONFIG_BROKEN=y List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Dec 13, 2005 at 07:28:41PM +0100, Geert Uytterhoeven wrote: > On Tue, 13 Dec 2005, Adrian Bunk wrote: > > Do not allow people to create configurations with CONFIG_BROKEN=y. > > > > The sole reason for CONFIG_BROKEN=y would be if you are working on > > fixing a broken driver, but in this case editing the Kconfig file is > > trivial. > > > > Never ever should a user enable CONFIG_BROKEN. > ^^^^ > OK, a user, not an expert. Let's assume users don't enable EXPERIMENTAL. Let's assume users don't have any hardware (e.g. several SATA drivers) that requires EXPERIMENTAL... > But I'd like to at least have the possibility to enable broken drivers, even if > it's just for compile regression tests. If a kernel developer really wants to enable BROKEN drivers, my patch still gives them the possibility to do so with a trivial edit of init/Kconfig. > Gr{oetje,eeting}s, > > Geert cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout.stusta.mhn.de (mailout.stusta.mhn.de [141.84.69.5]) by ozlabs.org (Postfix) with SMTP id 93AF768893 for ; Wed, 14 Dec 2005 05:51:50 +1100 (EST) Date: Tue, 13 Dec 2005 19:51:50 +0100 From: Adrian Bunk To: Geert Uytterhoeven Message-ID: <20051213185150.GP23349@stusta.de> References: <20051211185212.GQ23349@stusta.de> <20051211192109.GA22537@flint.arm.linux.org.uk> <20051211193118.GR23349@stusta.de> <20051211194437.GB22537@flint.arm.linux.org.uk> <20051213001028.GS23349@stusta.de> <439ECDCC.80707@hogyros.de> <20051213140001.GG23349@stusta.de> <20051213173112.GA24094@flint.arm.linux.org.uk> <20051213180551.GN23349@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: tony.luck@intel.com, linux-ia64@vger.kernel.org, grundler@parisc-linux.org, matthew@wil.cx, Linux Kernel Development , Linux/PPC Development , lethal@linux-sh.org, linux-mtd@lists.infradead.org, dwmw2@infradead.org, kkojima@rr.iij4u.or.jp, parisc-linux@parisc-linux.org Subject: Re: [2.6 patch] don't allow users to set CONFIG_BROKEN=y List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Dec 13, 2005 at 07:28:41PM +0100, Geert Uytterhoeven wrote: > On Tue, 13 Dec 2005, Adrian Bunk wrote: > > Do not allow people to create configurations with CONFIG_BROKEN=y. > > > > The sole reason for CONFIG_BROKEN=y would be if you are working on > > fixing a broken driver, but in this case editing the Kconfig file is > > trivial. > > > > Never ever should a user enable CONFIG_BROKEN. > ^^^^ > OK, a user, not an expert. Let's assume users don't enable EXPERIMENTAL. Let's assume users don't have any hardware (e.g. several SATA drivers) that requires EXPERIMENTAL... > But I'd like to at least have the possibility to enable broken drivers, even if > it's just for compile regression tests. If a kernel developer really wants to enable BROKEN drivers, my patch still gives them the possibility to do so with a trivial edit of init/Kconfig. > Gr{oetje,eeting}s, > > Geert cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932607AbVLMSvv (ORCPT ); Tue, 13 Dec 2005 13:51:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932609AbVLMSvv (ORCPT ); Tue, 13 Dec 2005 13:51:51 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:11279 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S932607AbVLMSvu (ORCPT ); Tue, 13 Dec 2005 13:51:50 -0500 Date: Tue, 13 Dec 2005 19:51:50 +0100 From: Adrian Bunk To: Geert Uytterhoeven Cc: Simon Richter , Linux Kernel Development , tony.luck@intel.com, linux-ia64@vger.kernel.org, matthew@wil.cx, grundler@parisc-linux.org, parisc-linux@parisc-linux.org, Paul Mackerras , Linux/PPC Development , lethal@linux-sh.org, kkojima@rr.iij4u.or.jp, dwmw2@infradead.org, linux-mtd@lists.infradead.org Subject: Re: [2.6 patch] don't allow users to set CONFIG_BROKEN=y Message-ID: <20051213185150.GP23349@stusta.de> References: <20051211185212.GQ23349@stusta.de> <20051211192109.GA22537@flint.arm.linux.org.uk> <20051211193118.GR23349@stusta.de> <20051211194437.GB22537@flint.arm.linux.org.uk> <20051213001028.GS23349@stusta.de> <439ECDCC.80707@hogyros.de> <20051213140001.GG23349@stusta.de> <20051213173112.GA24094@flint.arm.linux.org.uk> <20051213180551.GN23349@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 13, 2005 at 07:28:41PM +0100, Geert Uytterhoeven wrote: > On Tue, 13 Dec 2005, Adrian Bunk wrote: > > Do not allow people to create configurations with CONFIG_BROKEN=y. > > > > The sole reason for CONFIG_BROKEN=y would be if you are working on > > fixing a broken driver, but in this case editing the Kconfig file is > > trivial. > > > > Never ever should a user enable CONFIG_BROKEN. > ^^^^ > OK, a user, not an expert. Let's assume users don't enable EXPERIMENTAL. Let's assume users don't have any hardware (e.g. several SATA drivers) that requires EXPERIMENTAL... > But I'd like to at least have the possibility to enable broken drivers, even if > it's just for compile regression tests. If a kernel developer really wants to enable BROKEN drivers, my patch still gives them the possibility to do so with a trivial edit of init/Kconfig. > Gr{oetje,eeting}s, > > Geert cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed