Re: [patch 2/2] uml: Framebuffer driver for UML

[Jeff Dike <jdike@addtoit.com>]

On Tue, Dec 13, 2005 at 04:16:00PM +0100, Gerd Knorr wrote:
> $subject says pretty much all: This adds a framebuffer driver for UML.

> please apply,
> 
>   Gerd

Please don't.  This patch fails to link for me in -rc5 - the errors start like

drivers/built-in.o(.text+0x18b): In function `vgacon_deinit':
/home/jdike/linux/2.6/linux-2.6.15/drivers/video/console/vgacon.c:151: undefined reference to `outw'
drivers/built-in.o(.text+0x1a7):/home/jdike/linux/2.6/linux-2.6.15/drivers/video/console/vgacon.c:152: undefined reference to `outw'
drivers/built-in.o(.text+0x366): In function `vgacon_set_cursor_size':
/home/jdike/linux/2.6/linux-2.6.15/drivers/video/console/vgacon.c:430: undefined reference to `outb_p'
drivers/built-in.o(.text+0x375):/home/jdike/linux/2.6/linux-2.6.15/drivers/video/console/vgacon.c:431: undefined reference to `inb_p'
drivers/built-in.o(.text+0x396):/home/jdike/linux/2.6/linux-2.6.15/drivers/video/console/vgacon.c:432: undefined reference to `outb_p'
drivers/built-in.o(.text+0x3a5):/home/jdike/linux/2.6/linux-2.6.15/drivers/video/console/vgacon.c:433: undefined reference to `inb_p'

and go on for another couple hundred lines.

IIRC, I found fixes for these when I merged this into my tree.  It's a nice 
addition, but there are aspects of this that I don't like, which is why I
haven't sent it in myself.  Again, IIRC, enabling this disables the normal 
consoles, which is fairly unfriendly.

				Jeff