Re: [Bluez-devel] Remote name delay

[Johan Hedberg <johan.hedberg@nokia.com>]

Hi Claudio,

On Wed, Dec 14, 2005, Claudio Takahasi wrote:
> ok. We will extend the GetProperty(string:info) returning the
> following arguments:
> - MAC Address: String
> - Device Status: String(UP/DOWN)
> - Manufacturer: String
> - HCI Version: String
> - HCI Revision: String
> - LMP Version: String
> - LMP Sub Version: String

Currently we have three different property types: string, boolean and
byte. Are you proposing that the above information be bundled to one
"info" property? That would create a fourth property type which, in my
opinion, would complicate the code unecessarely. Maybe those pieces of
information should be split into one property each (or maybe that's what
you're suggesting, sorry if I misunderstood)? If there still exists a
complelling reason to bundle all that info into one property, then I'd
suggest creating a new property with the type DBUS_TYPE_STRUCT in order
to maintain consistency with the parameters of the property signal and
methods.

Also, all of the above pieces of information, excluding the device
status, are of a read-only nature so the SetProperty method and
PropertyChanged signal don't really apply to them. Therefore the
question should be asked whether the "properties" feature is the right
one to use for them (I'm not saying it isn't, just that it should be
questioned). E.g. you would need to think about what error should be
returned if SetProperty is called for one of them.

Thirdly, the device status information can already changed using the Up
and Down methods and its changes can be tracked using the Up and Down
signals, so adding it to the set of properties is probably not the right
thing to do (or then the Up/Down signals and methods should be removed).

Johan


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel