From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] ARM ethernet fixes
Date: Thu, 15 Dec 2005 00:00:05 +0000 [thread overview]
Message-ID: <200512150000.07159.paul@codesourcery.com> (raw)
In-Reply-To: <20051214221705.GA21427@nevyn.them.org>
On Wednesday 14 December 2005 22:17, Daniel Jacobowitz wrote:
> This is enough to let me use apt-get within qemu-system-arm :-)
I'd totally missed that there were _two_ TX FIFOs.
> @@ -364,6 +381,8 @@ static void smc91c111_writeb(void *opaqu
> return;
> case 12: /* Interrupt ACK. */
> s->int_level &= ~(value & 0xd6);
> + if (value & INT_TX)
> + smc91c111_pop_tx_fifo_done(s);
> smc91c111_update(s);
> return;
I'm fairly sure this is still wrong. We should only clear INT_TX if the tx
completion fifo is empty. Maybe have smc91c111_update set the INT_TX bit if
tx_fifo_done_len != 0.
You also need to make smc91c111_reset, smc91c111_writeb: bank 2 offset 0 cmd 2
(Reset MMU) and smc91c111_writeb: bank 2 offset 0 cmd 7 (Reset TX FIFO) set
s->tx_fifo_done_len = 0.
Paul
next prev parent reply other threads:[~2005-12-15 0:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 22:17 [Qemu-devel] ARM ethernet fixes Daniel Jacobowitz
2005-12-15 0:00 ` Paul Brook [this message]
2005-12-18 16:51 ` Paul Brook
2005-12-18 17:25 ` Daniel Jacobowitz
2005-12-18 17:42 ` M. Warner Losh
2005-12-18 17:53 ` Paul Brook
2005-12-18 20:31 ` M. Warner Losh
2005-12-18 17:54 ` Daniel Jacobowitz
2005-12-18 18:50 ` Dave Feustel
2005-12-18 21:57 ` [Qemu-devel] " Antti P Miettinen
2005-12-18 22:29 ` [Qemu-devel] ARM page crossing inside insn? (Re: ARM ethernet fixes) Antti P Miettinen
2005-12-19 9:40 ` [Qemu-devel] " Antti P Miettinen
2005-12-19 15:24 ` Antti P Miettinen
2005-12-19 16:53 ` Daniel Jacobowitz
2005-12-19 19:25 ` Antti P Miettinen
2005-12-26 2:30 ` Antti P Miettinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512150000.07159.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.