From: "Ville Syrjälä" <syrjala@sci.fi>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Petr Vandrovec <vandrove@vc.cvut.cz>
Subject: Re: [PATCH] cleanups to matroxfb_maven
Date: Thu, 15 Dec 2005 12:13:08 +0200 [thread overview]
Message-ID: <20051215101308.GA1744@sci.fi> (raw)
In-Reply-To: <20051214223132.35365ce1.khali@linux-fr.org>
On Wed, Dec 14, 2005 at 10:31:32PM +0100, Jean Delvare wrote:
> @@ -129,7 +129,7 @@
>
> struct maven_data {
> struct matrox_fb_info* primary_head;
> - struct i2c_client* client;
> + struct i2c_client client;
> int version;
> };
I think this change makes the patch unnecessarily large. Why not leave
the "client" as a pointer and allocate it separetely? That would reduce
the patch size considerably.
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id\x16865&op=click
prev parent reply other threads:[~2005-12-15 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 21:31 [PATCH] cleanups to matroxfb_maven Jean Delvare
2005-12-15 10:13 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051215101308.GA1744@sci.fi \
--to=syrjala@sci.fi \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.