From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965198AbVLOMW6 (ORCPT ); Thu, 15 Dec 2005 07:22:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965194AbVLOMW6 (ORCPT ); Thu, 15 Dec 2005 07:22:58 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:14220 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S965188AbVLOMW5 (ORCPT ); Thu, 15 Dec 2005 07:22:57 -0500 Date: Thu, 15 Dec 2005 12:22:53 +0000 From: Christoph Hellwig To: Roman Zippel Cc: Al Viro , Linus Torvalds , linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org Subject: Re: [PATCH 1/3] m68k: compile fix - hardirq checks were in wrong place Message-ID: <20051215122252.GA23407@infradead.org> Mail-Followup-To: Christoph Hellwig , Roman Zippel , Al Viro , Linus Torvalds , linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org References: <20051215085402.GT27946@ftp.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > You separate the definition from the check, now you push the > responsibility to get the order right to the header users. > Sorry, but I prefer to fix the header dependencies than scatter things > which belong together over multiple files. For 2.6.16 I'll submit a patch to merge asm/irq.h and asm/hardirq.h. Until then this is the much better fix because it doesn't require pointless include reordering all over the tree.