From mboxrd@z Thu Jan  1 00:00:00 1970
From: Murillo Bernardes <mfb@br.ibm.com>
Subject: Re: [PATCH] Talk_to_backend on xenbus_probe only if
	drv->probe was sucessful
Date: Thu, 15 Dec 2005 14:59:31 -0200
Message-ID: <200512151459.31712.mfb@br.ibm.com>
References: <200512121635.45358.mfb@br.ibm.com>
	<20051215133828.GB11024@leeni.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20051215133828.GB11024@leeni.uk.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ewan Mellor <ewan@xensource.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Thursday 15 December 2005 11:38, Ewan Mellor wrote:
> On Mon, Dec 12, 2005 at 04:35:45PM -0200, Murillo Bernardes wrote:
> > Hi,
> >
> > This patch makes xenbus_probe only call talk_to_backend if drv->probe()
> > was sucessful.
> >
> > There is no sense in add a watch before drv->probe, because if it fails
> > the otherend_changed callback will be called and receive a struct with
> > invalid pointers and we get a segfault (ooops).
>
> Applied, thanks Murillo.
>
> Ewan.
I just found a problem on that. It breaks block devices! I don't know why yet.

Do you know why block devices rely on that watch before probe?

Thanks


-- 
Murillo Fernandes Bernardes
IBM Linux Technology Center