From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Kumar Gala <galak@kernel.crashing.org>,
linux-ppc-embedded <linuxppc-embedded@ozlabs.org>
Cc: Daniel Belz <Daniel.Belz@cyclades.com>,
Edson Seabra <edson.seabra@cyclades.com>
Subject: [PATCH] MPC85xx: CPM2 interrupt handler failure after 100, 000 interrupts
Date: Fri, 16 Dec 2005 11:46:04 -0200 [thread overview]
Message-ID: <20051216134604.GA3692@dmt.cnet> (raw)
Hi Kumar,
Please apply.
From: Edson Seabra <Edson.Seabra@cyclades.com>
The CPM2 interrupt handler does not return success to the IRQ subsystem, which
causes it to kill the IRQ line after 100,000 interrupts.
[root@KVM ~]# create_cf --doformat --factory_default
...
Copying Linux kernel to /dev/hda1
Initialization of /dev/hda1 done.
Copying RO file system to /dev/hda5
Packing dev done.
Creating directories...
Creating etc... done.
Creating home... done.
Creating root... done.
Creating mnt... done.
Creating var... done.
Creating dev... done.
Creating tmp... done.
Creating proc... done.
Copying directories/files...
Copying bin... done.
Copying sbin... done.
Copying lib... done.
Copying libexec... done.
Copying new_web... done.
Copying opt... done.
Copying usr... done.
Copying COPYRIGHTS...
Error in command: 'cp -a /COPYRIGHTS /mnt/hdPart'
[ 1133.542580] Disabling IRQ #94
May 23 16:59:53 s_kernel@KVM [ 1133.542222] irq 94: nobody cared (try
booting with the "irqpoll" option)
May 23 16:59:53 s_kernel@KVM [ 1133.542546] handlers:
May 23 16:59:53 s_kernel@KVM [ 1133.542554] [<c0013ba4>]
(cpm2_cascade+0x0/0x48)
The following patch fixes the problem.
Signed-off-by: Edson Seabra <Edson.Seabra@cyclades.com>
Signed-off-by: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
RCS file: /usr/cvsroot/oobi_projects/sources/lsp/linux-2.6.14
/arch/ppc/platforms/85xx/mpc85xx_cds_common.c,v
retrieving revision 1.1
retrieving revision 1.4
diff -u -r1.1 -r1.4
--- a/arch/ppc/platforms/85xx/mpc85xx_cds_common.c 6 Dec 2005 02:56:21 -0000 1.1
+++ b/arch/ppc/platforms/85xx/mpc85xx_cds_common.c 14 Dec 2005 19:32:57 -0000 1.4
@@ -145,10 +154,11 @@
}
#ifdef CONFIG_CPM2
-static void cpm2_cascade(int irq, void *dev_id, struct pt_regs *regs)
+static int cpm2_cascade(int irq, void *dev_id, struct pt_regs *regs)
{
while((irq = cpm2_get_irq(regs)) >= 0)
__do_IRQ(irq, regs);
+ return(IRQ_HANDLED);
}
static struct irqaction cpm2_irqaction = {
reply other threads:[~2005-12-16 14:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051216134604.GA3692@dmt.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=Daniel.Belz@cyclades.com \
--cc=edson.seabra@cyclades.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.