From: Adrian Bunk <bunk@stusta.de>
To: Horst von Brand <vonbrand@inf.utfsm.cl>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [-mm patch] more updates for the gcc >= 3.2 requirement
Date: Fri, 16 Dec 2005 20:01:26 +0100 [thread overview]
Message-ID: <20051216190126.GF23349@stusta.de> (raw)
In-Reply-To: <200512161828.jBGISe4k003326@laptop11.inf.utfsm.cl>
On Fri, Dec 16, 2005 at 03:28:40PM -0300, Horst von Brand wrote:
> Adrian Bunk <bunk@stusta.de> wrote:
> > This patch contains some documentation updates and removes some code
> > paths for gcc < 3.2.
>
> [...]
>
> > --- linux-2.6.15-rc5-mm3-full/arch/arm/kernel/asm-offsets.c.old 2005-12-15 13:34:55.000000000 +0100
> > +++ linux-2.6.15-rc5-mm3-full/arch/arm/kernel/asm-offsets.c 2005-12-15 13:35:11.000000000 +0100
> > @@ -27,11 +27,11 @@
> > * GCC 3.2.0: incorrect function argument offset calculation.
> > * GCC 3.2.x: miscompiles NEW_AUX_ENT in fs/binfmt_elf.c
> > * (http://gcc.gnu.org/PR8896) and incorrect structure
> > * initialisation in fs/jffs2/erase.c
> > */
> > -#if __GNUC__ < 3 || (__GNUC__ == 3 && __GNUC_MINOR__ < 3)
> > +#if (__GNUC__ == 3 && __GNUC_MINOR__ < 3)
> > #error Your compiler is too buggy; it is known to miscompile kernels.
> > #error Known good compilers: 3.3
> > #endif
>
> Better leave the original, in case some clown comes along with an ancient
> compiler.
>...
That's what the check in init/main.c is for.
> > --- linux-2.6.15-rc5-mm3-full/include/asm-sparc64/system.h.old 2005-12-15 13:40:55.000000000 +0100
> > +++ linux-2.6.15-rc5-mm3-full/include/asm-sparc64/system.h 2005-12-15 13:41:03.000000000 +0100
> > @@ -191,15 +191,11 @@
> > * the output value of 'last'. 'next' is not referenced again
> > * past the invocation of switch_to in the scheduler, so we need
> > * not preserve it's value. Hairy, but it lets us remove 2 loads
> > * and 2 stores in this critical code path. -DaveM
> > */
> > -#if __GNUC__ >= 3
> > #define EXTRA_CLOBBER ,"%l1"
> > -#else
> > -#define EXTRA_CLOBBER
> > -#endif
>
> If EXTRA_CLOBBER is now constant, you can get rid of it completely.
>...
It's now a codingstyle issue, and DaveM (Cc'ed) can change it if he
wants to.
> Nice job!
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-12-16 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 21:24 [-mm patch] more updates for the gcc >= 3.2 requirement Adrian Bunk
2005-12-16 18:28 ` Horst von Brand
2005-12-16 19:01 ` Adrian Bunk [this message]
2005-12-17 1:04 ` Horst von Brand
2005-12-18 11:47 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051216190126.GF23349@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=vonbrand@inf.utfsm.cl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.