All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: Linus Torvalds <torvalds@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Input: fix an OOPS in HID driver
Date: Sat, 17 Dec 2005 11:40:27 -0500	[thread overview]
Message-ID: <200512171140.28029.dtor_core@ameritech.net> (raw)
In-Reply-To: <20051217102223.GB27280@midnight.suse.cz>

On Saturday 17 December 2005 05:22, Vojtech Pavlik wrote:
> On Fri, Dec 16, 2005 at 09:31:04PM -0500, Dmitry Torokhov wrote:
> > Subject: 
> > 
> > This patch fixes an OOPS in HID driver when connecting simulation
> > devices generating unknown simulation events.
> > 
> > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> 
> Yup, needed indeed. I'm not sure if we want an 'unknown': 'ignore'
> might be safer.

Well, 'unknown' restores the previous behavior (before simulation codes
were added to the driver) so it is pretty safe, however 'ignore' is indeed
more correct I think.

I will send an updated patch. Linus, if you already applied the original
one just ignore the new one - we can change it post 2.6.15 when we add
more simulation codes to HID driver.

-- 
Dmitry

  reply	other threads:[~2005-12-17 16:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-17  2:31 [PATCH] Input: fix an OOPS in HID driver Dmitry Torokhov
2005-12-17 10:22 ` Vojtech Pavlik
2005-12-17 16:40   ` Dmitry Torokhov [this message]
2005-12-17 16:42     ` Dmitry Torokhov
2005-12-22  0:15       ` Adrian Bunk
2005-12-22  4:08         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200512171140.28029.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.