From: Adrian Bunk <bunk@stusta.de>
To: Joel Becker <joel.becker@oracle.com>,
Mark Fasheh <mark.fasheh@oracle.com>,
Kurt Hackel <kurt.hackel@oracle.com>
Cc: linux-kernel@vger.kernel.org
Subject: [-mm patch] fs/ocfs2/: small cleanups
Date: Sat, 17 Dec 2005 22:30:56 +0100 [thread overview]
Message-ID: <20051217213056.GS23349@stusta.de> (raw)
This patch contains the following cleanups:
- cluster/sys.c: make needlessly global code static
- dlm/: "extern" declarations for variables belong into header files
(and in this case, they are already in dlmdomain.h)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
BTW: Could you add a MAINTAINERS entry for ocfs2?
fs/ocfs2/cluster/sys.c | 4 ++--
fs/ocfs2/dlm/dlmmaster.c | 4 +---
fs/ocfs2/dlm/dlmthread.c | 3 ---
3 files changed, 3 insertions(+), 8 deletions(-)
--- linux-2.6.15-rc5-mm3-full/fs/ocfs2/cluster/sys.c.old 2005-12-17 20:07:58.000000000 +0100
+++ linux-2.6.15-rc5-mm3-full/fs/ocfs2/cluster/sys.c 2005-12-17 20:09:46.000000000 +0100
@@ -50,7 +50,7 @@
return snprintf(buf, PAGE_SIZE, "%u\n", O2NM_API_VERSION);
}
-O2CB_ATTR(interface_revision, S_IFREG | S_IRUGO, o2cb_interface_revision_show, NULL);
+static O2CB_ATTR(interface_revision, S_IFREG | S_IRUGO, o2cb_interface_revision_show, NULL);
static struct attribute *o2cb_attrs[] = {
&o2cb_attr_interface_revision.attr,
@@ -73,7 +73,7 @@
};
/* gives us o2cb_subsys */
-decl_subsys(o2cb, NULL, NULL);
+static decl_subsys(o2cb, NULL, NULL);
static ssize_t
o2cb_show(struct kobject * kobj, struct attribute * attr, char * buffer)
--- linux-2.6.15-rc5-mm3-full/fs/ocfs2/dlm/dlmmaster.c.old 2005-12-17 20:10:22.000000000 +0100
+++ linux-2.6.15-rc5-mm3-full/fs/ocfs2/dlm/dlmmaster.c 2005-12-17 20:11:00.000000000 +0100
@@ -48,6 +48,7 @@
#include "dlmapi.h"
#include "dlmcommon.h"
#include "dlmdebug.h"
+#include "dlmdomain.h"
#define MLOG_MASK_PREFIX (ML_DLM|ML_DLM_MASTER)
#include "cluster/masklog.h"
@@ -173,9 +174,6 @@
spin_unlock(&dlm->master_lock);
}
-extern spinlock_t dlm_domain_lock;
-extern struct list_head dlm_domains;
-
int dlm_dump_all_mles(const char __user *data, unsigned int len)
{
struct list_head *iter;
--- linux-2.6.15-rc5-mm3-full/fs/ocfs2/dlm/dlmthread.c.old 2005-12-17 20:11:11.000000000 +0100
+++ linux-2.6.15-rc5-mm3-full/fs/ocfs2/dlm/dlmthread.c 2005-12-17 20:11:31.000000000 +0100
@@ -52,9 +52,6 @@
#define MLOG_MASK_PREFIX (ML_DLM|ML_DLM_THREAD)
#include "cluster/masklog.h"
-extern spinlock_t dlm_domain_lock;
-extern struct list_head dlm_domains;
-
static int dlm_thread(void *data);
static void dlm_flush_asts(struct dlm_ctxt *dlm);
next reply other threads:[~2005-12-17 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-17 21:30 Adrian Bunk [this message]
2005-12-19 19:16 ` [-mm patch] fs/ocfs2/: small cleanups Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051217213056.GS23349@stusta.de \
--to=bunk@stusta.de \
--cc=joel.becker@oracle.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.fasheh@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.