From: Paul Jackson <pj@sgi.com>
To: Paul Jackson <pj@sgi.com>
Cc: paulmck@us.ibm.com, akpm@osdl.org, dada1@cosmosbay.com,
linux-kernel@vger.kernel.org, nickpiggin@yahoo.com.au,
Simon.Derr@bull.net, ak@suse.de, Greg Edwards <edwardsg@sgi.com>,
clameter@sgi.com
Subject: CONFIG_DEBUG_PREEMPT (was: [PATCH 04/04] Cpuset: skip rcu check ...)
Date: Mon, 19 Dec 2005 08:04:01 -0800 [thread overview]
Message-ID: <20051219080401.861acca2.pj@sgi.com> (raw)
In-Reply-To: <20051219064810.0ec403ee.pj@sgi.com>
pj wrote:
> instead consider removing CONFIG_DEBUG_PREEMPT from at least sn2
Ah - perhaps not so. Adding my SGI colleague Greg Edwards to the cc
list. My email archives suggest that he enabled CONFIG_DEBUG_PREEMPT
in ia64 sn2_defconfig a few months ago, and I presume did so intentionally.
The change enabling CONFIG_DEBUG_PREEMPT was:
user: Greg Edwards <edwardsg@sgi.com>
date: Tue Aug 16 23:38:16 2005 +0011
summary: [IA64] Refresh arch/ia64/configs/sn2_defconfig.
Greg - CONFIG_DEBUG_PREEMPT adds a couple of pages of assembly code
due to various BUG checks beneath rcu_read_lock() on some hot code
paths (which is where rcu is most popular). See the two calls
add_preempt_count() and sub_preempt_count() in kernel/sched.c.
Was this intentional to enable CONFIG_DEBUG_PREEMPT in sn2_defconfig?
Other evidence opposing this DEBUG opttion:
Most other DEBUG options are turned off in the defconfigs.
Other evidence supporting setting this DEBUG option:
We're not the only arch enabling CONFIG_DEBUG_PREEMPT. See also:
collie simpad s390 se7705
lpd7a400 bigsur dreamcast sh03
lpd7a404 microdev systemh mx1ads
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2005-12-19 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 8:40 [PATCH 01/04] Cpuset: remove rcu slab cache optimization Paul Jackson
2005-12-14 8:40 ` [PATCH 02/04] Cpuset: use rcu directly optimization Paul Jackson
2005-12-16 17:55 ` Paul E. McKenney
2005-12-16 20:22 ` Paul Jackson
2005-12-14 8:40 ` [PATCH 03/04] Cpuset: mark number_of_cpusets read_mostly Paul Jackson
2005-12-14 8:40 ` [PATCH 04/04] Cpuset: skip rcu check if task is in root cpuset Paul Jackson
2005-12-16 17:52 ` Paul E. McKenney
2005-12-16 20:06 ` Paul Jackson
2005-12-17 16:47 ` Paul E. McKenney
2005-12-19 14:48 ` Paul Jackson
2005-12-19 16:04 ` Paul Jackson [this message]
2005-12-19 16:39 ` CONFIG_DEBUG_PREEMPT (was: [PATCH 04/04] Cpuset: skip rcu check ...) Greg Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051219080401.861acca2.pj@sgi.com \
--to=pj@sgi.com \
--cc=Simon.Derr@bull.net \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=dada1@cosmosbay.com \
--cc=edwardsg@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.