From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Anderson.Briglia@indt.org.br" <Anderson.Briglia@indt.org.br>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] MMC - CONFIG_HOTPLUG support
Date: Mon, 19 Dec 2005 13:04:36 +0000 [thread overview]
Message-ID: <20051219130436.GC11932@flint.arm.linux.org.uk> (raw)
In-Reply-To: <F26D8BDC5BC8014A909C6D45468F69EF022B680C@mzebe101.NOE.Nokia.com>
On Mon, Dec 19, 2005 at 09:52:59AM -0300, Anderson.Briglia@indt.org.br wrote:
> > > This patch improves the CONFIG_HOTPLUG support on the mmc core driver.
> > > Kernel version: 2.6.15-rc4-omap1
> >
> > Please explain how this "improves" the support.
>
> As we can see on usb core driver, there's a compiler directive that
> bypass the hotplug function if the CONFIG_HOTPLUG is not selected.
> I think I could add this "support" on the MMC driver. Just a
> optimization.
Just because some other subsystem does something does not make it
right for others to do the same. I'd like you to explain:
1. what additional support this patch gives us.
2. what the nature of the optimisation is.
> Please, correct me if I'm wrong.
I don't know if you're wrong because I don't understand the reasoning
behind the change.
next prev parent reply other threads:[~2005-12-19 13:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-16 19:50 [PATCH] MMC - CONFIG_HOTPLUG support Anderson Briglia
2005-12-16 21:58 ` Russell King - ARM Linux
2005-12-19 12:52 ` Anderson.Briglia
2005-12-19 13:04 ` Russell King - ARM Linux [this message]
2005-12-19 15:44 ` Juha Yrjölä
2005-12-19 16:02 ` Anderson.Briglia
2005-12-24 22:35 ` Russell King - ARM Linux
2005-12-26 18:46 ` Anderson.Briglia
2005-12-31 16:00 ` Russell King - ARM Linux
-- strict thread matches above, loose matches on Subject: below --
2005-12-16 19:51 Anderson Briglia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051219130436.GC11932@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Anderson.Briglia@indt.org.br \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.