From: Al Viro <viro@ftp.linux.org.uk>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
ralf@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: namespace pollution: dump_regs() -> elf_dump_regs()
Date: Mon, 19 Dec 2005 16:07:14 +0000 [thread overview]
Message-ID: <20051219160714.GI27946@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64N.0512191159440.23348@blysk.ds.pg.gda.pl>
On Mon, Dec 19, 2005 at 12:07:09PM +0000, Maciej W. Rozycki wrote:
> On Fri, 16 Dec 2005, Al Viro wrote:
>
> > dump_regs() is used by a bunch of drivers for their internal stuff;
> > renamed mips instance (one that is seen in system-wide headers)
> > to elf_dump_regs()
>
> I guess drivers should be fixed not to use generic names in the first
> place -> s/dump_regs/frobnicator_dump_regs/, etc.
No. If nothing else, it's far less work to keep the headers reasonably
clean than to slap prefices on every damn static-in-file function
out there. Leads to more readable code in drivers, too...
next prev parent reply other threads:[~2005-12-19 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-16 22:40 [PATCH] mips: namespace pollution: dump_regs() -> elf_dump_regs() Al Viro
2005-12-17 22:20 ` Ralf Baechle
2005-12-19 12:07 ` Maciej W. Rozycki
2005-12-19 16:07 ` Al Viro [this message]
2005-12-20 12:16 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051219160714.GI27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.