All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH 1/7] i2c: scx200_acb - whitespace and
Date: Mon, 19 Dec 2005 20:23:45 +0000	[thread overview]
Message-ID: <20051219212345.6f3b2fec.khali@linux-fr.org> (raw)
In-Reply-To: <808c8e9d0512191049t5050cd42w82b65f03dd350a7b@mail.gmail.com>

Hi Ben,

> scx200_acb whitespace and comment cleanup.

Looks like you have been over-zealous here. These three types of
changes in this patch are not really wanted:

> -#define NAME "scx200_acb"
> +#define NAME		"scx200_acb"

> -	struct scx200_acb_iface *next;
> -	struct i2c_adapter adapter;
> -	unsigned base;
> -	struct semaphore sem;
> +	struct scx200_acb_iface	*next;
> +	struct i2c_adapter	adapter;
> +	unsigned		base;
> +	struct semaphore	sem;

>  			iface->result = 0;
> -			iface->state = state_idle;
> +			iface->state  = state_idle;

Given that different developers like it differently and there is no
absolute rule for these points, and given that the scx200_acb driver is
consistent with regards to these points, I'd leave the current code as
it is.

All other changes (in this patch) I am fine with.

Thanks,
-- 
Jean Delvare


  reply	other threads:[~2005-12-19 20:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-19 18:49 [lm-sensors] [PATCH 1/7] i2c: scx200_acb - whitespace and comment Ben Gardner
2005-12-19 20:23 ` Jean Delvare [this message]
2005-12-19 21:12 ` [lm-sensors] [PATCH 1/7] i2c: scx200_acb - whitespace and Ben Gardner
2005-12-20 19:55 ` Jean Delvare
2005-12-20 22:54 ` [lm-sensors] [PATCH 1/7] i2c: scx200_acb - whitespace and comment Ben Gardner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051219212345.6f3b2fec.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.