From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [Patch 2/5] Cleanup MIN/MAX Macro usage in eicon/di.c
Date: Tue, 20 Dec 2005 13:54:38 +0000 [thread overview]
Message-ID: <20051220135438.GU2361@parisc-linux.org> (raw)
In-Reply-To: <1135084556.24065.6.camel@alice>
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
On Tue, Dec 20, 2005 at 02:15:56PM +0100, Eric Sesterhenn / snakebyte wrote:
> - clength = MIN((word)(270-length),X[i].PLength-this->XOffset);
> + clength = min((word)(270-length),(word)(X[i].PLength-this->XOffset));
perhaps you should use min_t?
> - IoAdapter->RBuffer.length = MIN(MLength, 270);
> + IoAdapter->RBuffer.length = min((word)MLength, (word)270);
likewise.
> - clength = MIN(MLength, R[this->RCurrent].PLength-this->ROffset);
> + clength = min(MLength, (word)(R[this->RCurrent].PLength-this->ROffset));
likewise.
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-12-20 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-20 13:15 [KJ] [Patch 2/5] Cleanup MIN/MAX Macro usage in eicon/di.c Eric Sesterhenn / snakebyte
2005-12-20 13:54 ` Matthew Wilcox [this message]
2005-12-20 15:05 ` Eric Sesterhenn / snakebyte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051220135438.GU2361@parisc-linux.org \
--to=matthew@wil.cx \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.