All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Daniel Walker <dwalker@mvista.com>,
	Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Subject: Re: [PATCH rc5-rt2 0/3] plist: alternative implementation
Date: Tue, 20 Dec 2005 15:38:48 +0100	[thread overview]
Message-ID: <20051220143848.GA2053@elte.hu> (raw)
In-Reply-To: <43A5A7B5.21A4CAAE@tv-sign.ru>


* Oleg Nesterov <oleg@tv-sign.ru> wrote:

> Rediff against patch-2.6.15-rc5-rt2.
> 
> Nothing was changed except s/plist_next_entry/plist_first_entry/ to 
> match the current naming.

thanks Oleg, your patches look good to me, and it's a worthwile cleanup 
to make plist.h ops behave more like normal list.h ops. The new ops 
should be documented, but otherwise it looks OK.

(the resulting kernel doesnt build in PREEMPT_RT mode though, it's 
lib/plist.c not being converted yet?)

> These patches were only compile tested. This is beacuse I can't even 
> compile 2.6.15-rc5-rt2, I had to comment out this line
> 
> 	lib-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += rwsem.o
> 
> in lib/Makefile. I think CONFIG_RWSEM_GENERIC_SPINLOCK means that 
> lib/rwsem.c should be ignored.
> 
> After that the kernel panics at boot time, the call trace shows
> 
> 	set_workqueue_thread_prio
> 	wake_up_process
> 	set_workqueue_prio
> 	init_workqueues
> 
> will try to look further on Tuesday.
> 
> Just to make it clear, these problems were _without_ these patches.

please try the -rt3 kernel, does it work any better?

	Ingo

  parent reply	other threads:[~2005-12-20 14:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-18 18:17 [PATCH rc5-rt2 0/3] plist: alternative implementation Oleg Nesterov
2005-12-18 17:21 ` Steven Rostedt
2005-12-18 17:25   ` Steven Rostedt
2005-12-20 14:38 ` Ingo Molnar [this message]
2005-12-20 16:08   ` Oleg Nesterov
2005-12-20 15:04     ` Ingo Molnar
2005-12-20 16:11   ` Oleg Nesterov
2005-12-20 16:34   ` Daniel Walker
2005-12-20 18:31     ` Oleg Nesterov
2005-12-20 17:29       ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051220143848.GA2053@elte.hu \
    --to=mingo@elte.hu \
    --cc=dwalker@mvista.com \
    --cc=inaky.perez-gonzalez@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.