From: Jens Axboe <axboe@suse.de>
To: john stultz <johnstul@us.ibm.com>
Cc: Ben Collins <ben.collins@ubuntu.com>,
lkml <linux-kernel@vger.kernel.org>,
greg@kroah.com
Subject: Re: [PATCH] block: Better CDROMEJECT
Date: Tue, 20 Dec 2005 21:54:25 +0100 [thread overview]
Message-ID: <20051220205425.GT3734@suse.de> (raw)
In-Reply-To: <1135111300.27117.41.camel@cog.beaverton.ibm.com>
On Tue, Dec 20 2005, john stultz wrote:
> Although from just looking at it, don't you still need to add
> ALLOW_MEDIUM_REMOVAL in the verify_command() list for this to work?
>
> Alternatively, would just the "safe_for_write(ALLOW_MEDIUM_REMOVAL);" in
> verify_command along with the eject-opens-RW fix have almost the same
> effect?
The command is already in the safe-for-write list, so you don't have to
change anything but fix eject to open the device O_RDWR.
--
Jens Axboe
next prev parent reply other threads:[~2005-12-20 20:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-20 2:51 [RFC] Let non-root users eject their ipods? john stultz
2005-12-20 3:51 ` Wakko Warner
2005-12-20 3:49 ` john stultz
2005-12-20 5:05 ` Matthew Dharm
2005-12-24 21:16 ` Jan Engelhardt
2005-12-20 5:18 ` Willy Tarreau
2005-12-20 6:06 ` Coywolf Qi Hunt
2005-12-20 8:56 ` Sander
2005-12-20 9:31 ` Coywolf Qi Hunt
2005-12-20 9:38 ` Sander
2005-12-20 16:39 ` Bill Davidsen
2005-12-20 11:10 ` Nikita Danilov
2005-12-20 7:46 ` Jens Axboe
2005-12-20 12:41 ` Ben Collins
2005-12-20 13:28 ` Jens Axboe
2005-12-20 13:32 ` Ben Collins
2005-12-20 13:39 ` Jens Axboe
2005-12-20 14:07 ` [PATCH] block: Better CDROMEJECT Ben Collins
2005-12-20 14:16 ` Jens Axboe
2005-12-20 20:41 ` john stultz
2005-12-20 20:54 ` Jens Axboe [this message]
2005-12-20 20:55 ` john stultz
2005-12-20 20:58 ` Jens Axboe
2005-12-20 20:58 ` john stultz
2005-12-20 20:55 ` Ben Collins
2005-12-20 16:48 ` [RFC] Let non-root users eject their ipods? Bill Davidsen
2005-12-22 10:56 ` Alan Cox
2005-12-22 16:57 ` john stultz
2005-12-24 21:17 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051220205425.GT3734@suse.de \
--to=axboe@suse.de \
--cc=ben.collins@ubuntu.com \
--cc=greg@kroah.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.