From: Adrian Bunk <bunk@stusta.de>
To: Dave Jones <davej@redhat.com>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: remove incorrect dependancy on CONFIG_APM
Date: Fri, 23 Dec 2005 03:18:13 +0100 [thread overview]
Message-ID: <20051223021813.GH27525@stusta.de> (raw)
In-Reply-To: <20051220212127.GA6833@redhat.com>
On Tue, Dec 20, 2005 at 04:21:27PM -0500, Dave Jones wrote:
>
> >From the PM_LEGACY Kconfig description..
>
> "Support for pm_register() and friends."
>
> Note, no mention of 'make apm stop working'.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6.14/arch/i386/Kconfig~ 2005-12-20 16:19:17.000000000 -0500
> +++ linux-2.6.14/arch/i386/Kconfig 2005-12-20 16:19:21.000000000 -0500
> @@ -710,7 +710,7 @@ depends on PM && !X86_VISWS
>
> config APM
> tristate "APM (Advanced Power Management) BIOS support"
> - depends on PM && PM_LEGACY
> + depends on PM
>...
This doesn't compile:
<-- snip -->
...
CC arch/i386/kernel/apm.o
arch/i386/kernel/apm.c: In function 'apm_init':
arch/i386/kernel/apm.c:2304: error: 'pm_active' undeclared (first use in this function)
arch/i386/kernel/apm.c:2304: error: (Each undeclared identifier is reported only once
arch/i386/kernel/apm.c:2304: error: for each function it appears in.)
arch/i386/kernel/apm.c: In function 'apm_exit':
arch/i386/kernel/apm.c:2410: error: 'pm_active' undeclared (first use in this function)
make[1]: *** [arch/i386/kernel/apm.o] Error 1
<-- snip -->
If PM_LEGACY causes user confusion for APM users, commit
bca73e4bf8563d83f7856164caa44d5f42e44cca should be reverted.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-12-23 2:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-20 21:21 remove incorrect dependancy on CONFIG_APM Dave Jones
2005-12-23 2:18 ` Adrian Bunk [this message]
2005-12-23 2:22 ` Dave Jones
2005-12-23 3:11 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051223021813.GH27525@stusta.de \
--to=bunk@stusta.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.