From: Matt Mackall <mpm@selenic.com>
To: Christoph Hellwig <hch@infradead.org>,
Dave Jones <davej@redhat.com>,
"Bryan O'Sullivan" <bos@pathscale.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [RFC] [PATCH] Add memcpy32 function
Date: Fri, 23 Dec 2005 12:14:53 -0600 [thread overview]
Message-ID: <20051223181453.GS3356@waste.org> (raw)
In-Reply-To: <20051223174228.GA29679@infradead.org>
On Fri, Dec 23, 2005 at 05:42:28PM +0000, Christoph Hellwig wrote:
> On Fri, Dec 23, 2005 at 11:16:28AM -0600, Matt Mackall wrote:
> > > io.h is a very generic sounding name for something that just houses
> > > a memcpy variant. What's wrong with calling a spade a spade,
> > > and using memcpy32.h ?
> >
> > I think it belongs in string.h alongside memcpy, just for tradition's
> > sake. I don't think it belongs in a file named io.h, as it probably
> > has uses beyond I/O.
>
> Actually I think memcpy32 is not the thing pathscale wants. They want
> memcpy_{to,from}_io32, because memcpy32 wouldn't be allowed to operate
> on I/O mapped memory. I'd say back to the drawingboard.
Ahh, excellent point. We probably want something closer to
iowrite32_rep and have it live in iomap.h. Perhaps iowrite32_copy?
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2005-12-23 18:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-23 1:35 [RFC] [PATCH] Add memcpy32 function Bryan O'Sullivan
2005-12-23 2:49 ` Dave Jones
2005-12-23 17:16 ` Matt Mackall
2005-12-23 17:42 ` Christoph Hellwig
2005-12-23 18:14 ` Matt Mackall [this message]
2005-12-23 23:50 ` Bryan O'Sullivan
2005-12-28 11:01 ` Andi Kleen
2005-12-28 15:00 ` Bryan O'Sullivan
2005-12-28 17:50 ` Andreas Kleen
2005-12-28 18:11 ` Bryan O'Sullivan
2005-12-28 18:22 ` Andreas Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051223181453.GS3356@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=bos@pathscale.com \
--cc=davej@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.