From: "Fernando J. Pereda" <ferdy@ferdyx.org>
To: git <git@vger.kernel.org>
Subject: Re: [PATCH] qgit: allow overriding CCFLAGS
Date: Sat, 24 Dec 2005 00:29:34 +0100 [thread overview]
Message-ID: <20051223232934.GA28582@ferdyx.org> (raw)
In-Reply-To: <1135380226.18431.21.camel@dv>
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Fri, Dec 23, 2005 at 06:23:46PM -0500, Pavel Roskin wrote:
| This patch allows overriding CCFLAGS by setting an environment variable
| or an argument to make.
That'd be nice... I have an ugly sed in the Gentoo ebuild to workaround
that. However...
| -env.Append( CCFLAGS = ['-O2', '-Wall' ,'-Wno-non-virtual-dtor'] )
| +env.Append( CCFLAGS = os.environ.get('CCFLAGS', ['-O2', '-Wall', '-Wno-non-virtual-dtor']) )
... shouldn't the enviroment variable be CXXFLAGS ?
Cheers,
Ferdy
--
Fernando J. Pereda Garcimartín
Gentoo Developer (Alpha,net-mail,mutt,git)
20BB BDC3 761A 4781 E6ED ED0B 0A48 5B0C 60BD 28D4
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-12-23 23:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-23 23:23 [PATCH] qgit: allow overriding CCFLAGS Pavel Roskin
2005-12-23 23:29 ` Fernando J. Pereda [this message]
2005-12-24 6:17 ` Marco Costalba
2005-12-24 8:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051223232934.GA28582@ferdyx.org \
--to=ferdy@ferdyx.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.