From: Al Viro <viro@ftp.linux.org.uk>
To: Kees Cook <kees@outflux.net>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib: zlib_inflate "r.base" uninitialized compile warnings
Date: Sun, 25 Dec 2005 18:34:06 +0000 [thread overview]
Message-ID: <20051225183406.GB27946@ftp.linux.org.uk> (raw)
In-Reply-To: <20051225180758.GM18040@outflux.net>
On Sun, Dec 25, 2005 at 10:07:58AM -0800, Kees Cook wrote:
> Eliminates compile-time warnings from "r" being uninitialized.
NAK. That sort of patches is only going to hide real problems in the
code where such warnings are _not_ false positives.
Let me put it that way: what bug are you fixing in that patch? Is
there a codepath that would lead to use of r without initialization?
If there is - show it; if there is not - why are you patching kernel
and not gcc?
next prev parent reply other threads:[~2005-12-25 18:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-25 18:07 [PATCH] lib: zlib_inflate "r.base" uninitialized compile warnings Kees Cook
2005-12-25 18:34 ` Al Viro [this message]
2005-12-25 20:39 ` Kees Cook
-- strict thread matches above, loose matches on Subject: below --
2005-12-25 20:08 James Lamanna
2005-12-25 20:35 ` Kees Cook
2005-12-25 20:43 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051225183406.GB27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=kees@outflux.net \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.