From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Hanquez Subject: Re: [PATCH] Prevent vbd frontend from oopsing if the underlying device doesn't exist Date: Tue, 27 Dec 2005 16:31:52 +0100 Message-ID: <20051227153152.GA4126@snarc.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Horms Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, Dec 26, 2005 at 08:55:45AM +0000, Horms wrote: > Prevent vbd frontend from oopsing if the underlying device doesn't exist. > > connect() in blkfront.c was not checking the return value of xlvbd_add(). > In my case xlvbd_alloc_gendisk() was failing in xlvbd_add(), and the > subsequent call to kick_pending_request_queues() barfed because info->rq > was unitinialised. Thanks, applied. -- Vincent Hanquez