All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mulyadi Santosa <a_mulyadi@softhome.net>
To: qemu-devel@nongnu.org, Andre Pech <andre.pech@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Fix to gdb - wrong translation block invalidated when setting gdb breakpoints
Date: Wed, 28 Dec 2005 15:22:35 +0700	[thread overview]
Message-ID: <200512281522.35505.a_mulyadi@softhome.net> (raw)
In-Reply-To: <16af12af0512231157n4efb01eemd4afbca65dea9d4@mail.gmail.com>

Hello Andre....

> breakpoint was hit. I finally tracked down the problem to
> exec.c:breakpoint_invalidate. The problem is that
> breakpoint_invalidate, which is supposed to invalidate the
> translation block for the address you want to break at, was
> actualling invalidating the translation block for the base address of
> the page that contained your breakpoint address. The fix is actually
> very simple and is attached below.

Thanks for the patch :) I will test the patch ASAP. Anyway, while the 
fix seems "simple", I am sure it wasn't easy to track down the real 
problem. Checking briefly (by eye, not via debugger or tons of printf() 
), one will skip those lines because he/she will think the function  is 
invalidating the correct physical address (returned 
cpu_get_phys_page_debug() ). Great work!

NB: Althought it is a bit late, but it's never too late...Merry 
Christmast!

regards

Mulyadi

  reply	other threads:[~2005-12-28  8:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-23 19:57 [Qemu-devel] [PATCH] Fix to gdb - wrong translation block invalidated when setting gdb breakpoints Andre Pech
2005-12-28  8:22 ` Mulyadi Santosa [this message]
     [not found]   ` <16af12af0512301218k48fecbdcr6ec41640b303689@mail.gmail.com>
2006-01-01  8:10     ` Mulyadi Santosa
2006-01-03 20:12       ` Andre Pech
2006-01-04 10:29         ` Mulyadi Santosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200512281522.35505.a_mulyadi@softhome.net \
    --to=a_mulyadi@softhome.net \
    --cc=andre.pech@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.