From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: pwm: Add support for MX53
Date: Wed, 24 Aug 2011 10:33:58 +0200 [thread overview]
Message-ID: <20052.46966.58705.657385@ipc1.ka-ro> (raw)
In-Reply-To: <20110824082504.GJ16557@pengutronix.de>
Uwe Kleine-K?nig writes:
> Hello Fabio,
>
> On Tue, Aug 23, 2011 at 01:26:38PM -0300, Fabio Estevam wrote:
> > Instead of adding the check for MX53 CPU type, use the negative logic and let
> > PWM to be configured for MX53 as well.
> I wonder why you prefer negative logic here. It might be shorter, but it
> is also less robust. For example it seems to me you not only added
> support for i.MX53 but also i.MX50.
>
> The IMHO best solution would be to use device ids and get rid of
> cpu_is_mx.. completely.
>
+1
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
prev parent reply other threads:[~2011-08-24 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 16:26 [PATCH] ARM: imx: pwm: Add support for MX53 Fabio Estevam
2011-08-24 8:18 ` Sascha Hauer
2011-08-24 8:25 ` Uwe Kleine-König
2011-08-24 8:33 ` Lothar Waßmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20052.46966.58705.657385@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.