From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:37324 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964811AbcDYVHi (ORCPT ); Mon, 25 Apr 2016 17:07:38 -0400 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Sergei Shtylyov , David Airlie , DRI Development , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] rcar-du: add/rename DEFR6 TCON bits Date: Tue, 26 Apr 2016 00:07:59 +0300 Message-ID: <20054207.ltPEUenxrn@avalon> In-Reply-To: References: <2036550.BKBaf2zquB@wasted.cogentembedded.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Geert, On Monday 25 Apr 2016 09:25:30 Geert Uytterhoeven wrote: > On Sat, Apr 23, 2016 at 12:56 AM, Sergei Shtylyov wrote: > > The TCNE2 bit of the DEFR6 register was renamed to TCNE1 in the R-Car > > gen2 manuals -- which makes more sense as that bit controls whether DU1, > > not DU2 is connected to TCON. > > > > While at it, add the TCNE0 bit which controls whether DU0 is connected to > > TCON. > > > > Based on the large patch by Andrey Gusakov > > . > > > > Signed-off-by: Andrey Gusakov > > Signed-off-by: Sergei Shtylyov > > I hard a hard time finding this register, as it's actually called "DEF6R"... > Care to update /DEFRx/DEFxR/ as well? Inconsistent information between datasheet versions I'm afraid, and even between different registers in a single datasheet. We have DEFR0, DEFR1, and then DEFxR. I wonder if it's worth renaming the registers. > Regardless: > Reviewed-by: Geert Uytterhoeven > > > --- > > The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch. > > > > drivers/gpu/drm/rcar-du/rcar_du_regs.h | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > Index: linux/drivers/gpu/drm/rcar-du/rcar_du_regs.h > > =================================================================== > > --- linux.orig/drivers/gpu/drm/rcar-du/rcar_du_regs.h > > +++ linux/drivers/gpu/drm/rcar-du/rcar_du_regs.h > > @@ -195,9 +195,10 @@ > > > > #define DEFR6_ODPM12_DISP (2 << 8) > > #define DEFR6_ODPM12_CDE (3 << 8) > > #define DEFR6_ODPM12_MASK (3 << 8) > > > > -#define DEFR6_TCNE2 (1 << 6) > > +#define DEFR6_TCNE1 (1 << 6) > > +#define DEFR6_TCNE0 (1 << 4) > > > > #define DEFR6_MLOS1 (1 << 2) > > > > -#define DEFR6_DEFAULT (DEFR6_CODE | DEFR6_TCNE2) > > +#define DEFR6_DEFAULT (DEFR6_CODE | DEFR6_TCNE1) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] rcar-du: add/rename DEFR6 TCON bits Date: Tue, 26 Apr 2016 00:07:59 +0300 Message-ID: <20054207.ltPEUenxrn@avalon> References: <2036550.BKBaf2zquB@wasted.cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D9E96E63E for ; Mon, 25 Apr 2016 21:07:37 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Geert Uytterhoeven Cc: linux-renesas-soc@vger.kernel.org, DRI Development , Sergei Shtylyov List-Id: dri-devel@lists.freedesktop.org SGkgR2VlcnQsCgpPbiBNb25kYXkgMjUgQXByIDIwMTYgMDk6MjU6MzAgR2VlcnQgVXl0dGVyaG9l dmVuIHdyb3RlOgo+IE9uIFNhdCwgQXByIDIzLCAyMDE2IGF0IDEyOjU2IEFNLCBTZXJnZWkgU2h0 eWx5b3Ygd3JvdGU6Cj4gPiBUaGUgIFRDTkUyIGJpdCAgb2YgdGhlIERFRlI2IHJlZ2lzdGVyIHdh cyByZW5hbWVkIHRvIFRDTkUxIGluIHRoZSBSLUNhcgo+ID4gZ2VuMiBtYW51YWxzIC0tIHdoaWNo IG1ha2VzIG1vcmUgIHNlbnNlIGFzIHRoYXQgYml0IGNvbnRyb2xzIHdoZXRoZXIgRFUxLAo+ID4g bm90IERVMiBpcyBjb25uZWN0ZWQgdG8gVENPTi4KPiA+IAo+ID4gV2hpbGUgYXQgaXQsIGFkZCB0 aGUgVENORTAgYml0IHdoaWNoIGNvbnRyb2xzIHdoZXRoZXIgRFUwIGlzIGNvbm5lY3RlZCB0bwo+ ID4gVENPTi4KPiA+IAo+ID4gQmFzZWQgb24gdGhlIGxhcmdlIHBhdGNoIGJ5IEFuZHJleSBHdXNh a292Cj4gPiA8YW5kcmV5Lmd1c2Frb3ZAY29nZW50ZW1iZWRkZWQuY29tPi4KPiA+IAo+ID4gU2ln bmVkLW9mZi1ieTogQW5kcmV5IEd1c2Frb3YgPGFuZHJleS5ndXNha292QGNvZ2VudGVtYmVkZGVk LmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFNlcmdlaSBTaHR5bHlvdiA8c2VyZ2VpLnNodHlseW92 QGNvZ2VudGVtYmVkZGVkLmNvbT4KPiAKPiBJIGhhcmQgYSBoYXJkIHRpbWUgZmluZGluZyB0aGlz IHJlZ2lzdGVyLCBhcyBpdCdzIGFjdHVhbGx5IGNhbGxlZCAiREVGNlIiLi4uCj4gQ2FyZSB0byB1 cGRhdGUgL0RFRlJ4L0RFRnhSLyBhcyB3ZWxsPwoKSW5jb25zaXN0ZW50IGluZm9ybWF0aW9uIGJl dHdlZW4gZGF0YXNoZWV0IHZlcnNpb25zIEknbSBhZnJhaWQsIGFuZCBldmVuIApiZXR3ZWVuIGRp ZmZlcmVudCByZWdpc3RlcnMgaW4gYSBzaW5nbGUgZGF0YXNoZWV0LiBXZSBoYXZlIERFRlIwLCBE RUZSMSwgYW5kIAp0aGVuIERFRnhSLiBJIHdvbmRlciBpZiBpdCdzIHdvcnRoIHJlbmFtaW5nIHRo ZSByZWdpc3RlcnMuCgo+IFJlZ2FyZGxlc3M6Cj4gUmV2aWV3ZWQtYnk6IEdlZXJ0IFV5dHRlcmhv ZXZlbiA8Z2VlcnQrcmVuZXNhc0BnbGlkZXIuYmU+Cj4gCj4gPiAtLS0KPiA+IFRoZSBwYXRjaCBp cyBhZ2FpbnN0IERhdmlkIEFpcmxpZSdzICdsaW51eC5naXQnIHJlcG8ncyAnZHJtLW5leHQnIGJy YW5jaC4KPiA+IAo+ID4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfcmVncy5oIHwg ICAgNSArKystLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCj4gPiAKPiA+IEluZGV4OiBsaW51eC9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2Fy X2R1X3JlZ3MuaAo+ID4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQo+ID4gLS0tIGxpbnV4Lm9yaWcvZHJpdmVycy9ncHUv ZHJtL3JjYXItZHUvcmNhcl9kdV9yZWdzLmgKPiA+ICsrKyBsaW51eC9kcml2ZXJzL2dwdS9kcm0v cmNhci1kdS9yY2FyX2R1X3JlZ3MuaAo+ID4gQEAgLTE5NSw5ICsxOTUsMTAgQEAKPiA+IAo+ID4g ICNkZWZpbmUgREVGUjZfT0RQTTEyX0RJU1AgICAgICAoMiA8PCA4KQo+ID4gICNkZWZpbmUgREVG UjZfT0RQTTEyX0NERSAgICAgICAoMyA8PCA4KQo+ID4gICNkZWZpbmUgREVGUjZfT0RQTTEyX01B U0sgICAgICAoMyA8PCA4KQo+ID4gCj4gPiAtI2RlZmluZSBERUZSNl9UQ05FMiAgICAgICAgICAg ICgxIDw8IDYpCj4gPiArI2RlZmluZSBERUZSNl9UQ05FMSAgICAgICAgICAgICgxIDw8IDYpCj4g PiArI2RlZmluZSBERUZSNl9UQ05FMCAgICAgICAgICAgICgxIDw8IDQpCj4gPiAKPiA+ICAjZGVm aW5lIERFRlI2X01MT1MxICAgICAgICAgICAgKDEgPDwgMikKPiA+IAo+ID4gLSNkZWZpbmUgREVG UjZfREVGQVVMVCAgICAgICAgICAoREVGUjZfQ09ERSB8IERFRlI2X1RDTkUyKQo+ID4gKyNkZWZp bmUgREVGUjZfREVGQVVMVCAgICAgICAgICAoREVGUjZfQ09ERSB8IERFRlI2X1RDTkUxKQoKLS0g ClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK