All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: zhaoxiao <zhaoxiao@uniontech.com>, rostedt <rostedt@goodmis.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	"Joel Fernandes, Google" <joel@joelfernandes.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracepoint: Fix the comment style
Date: Mon, 16 Aug 2021 10:02:50 -0400 (EDT)	[thread overview]
Message-ID: <2005434147.15227.1629122570891.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20210816052430.16539-1-zhaoxiao@uniontech.com>

----- On Aug 16, 2021, at 1:24 AM, zhaoxiao zhaoxiao@uniontech.com wrote:

> Fix function name in tracepoint.c kernel-doc comment
> to remove a warning found by clang_w1.
> 
> kernel/tracepoint.c:589: warning: expecting prototype for
> register_tracepoint_notifier(). Prototype was for
> register_tracepoint_module_notifier() instead
> kernel/tracepoint.c:613: warning: expecting prototype for
> unregister_tracepoint_notifier(). Prototype was for
> unregister_tracepoint_module_notifier() instead

Thanks!

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

> 
> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
> ---
> kernel/tracepoint.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
> index efd14c79fab4..64ea283f2f86 100644
> --- a/kernel/tracepoint.c
> +++ b/kernel/tracepoint.c
> @@ -577,7 +577,7 @@ bool trace_module_has_bad_taint(struct module *mod)
> static BLOCKING_NOTIFIER_HEAD(tracepoint_notify_list);
> 
> /**
> - * register_tracepoint_notifier - register tracepoint coming/going notifier
> + * register_tracepoint_module_notifier - register tracepoint coming/going
> notifier
>  * @nb: notifier block
>  *
>  * Notifiers registered with this function are called on module
> @@ -603,7 +603,7 @@ int register_tracepoint_module_notifier(struct
> notifier_block *nb)
> EXPORT_SYMBOL_GPL(register_tracepoint_module_notifier);
> 
> /**
> - * unregister_tracepoint_notifier - unregister tracepoint coming/going notifier
> + * unregister_tracepoint_module_notifier - unregister tracepoint coming/going
> notifier
>  * @nb: notifier block
>  *
>  * The notifier block callback should expect a "struct tp_module" data
> --
> 2.20.1

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

      reply	other threads:[~2021-08-16 14:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16  5:24 [PATCH] tracepoint: Fix the comment style zhaoxiao
2021-08-16 14:02 ` Mathieu Desnoyers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2005434147.15227.1629122570891.JavaMail.zimbra@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=gustavoars@kernel.org \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=zhaoxiao@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.