From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6357753444B for ; Thu, 10 Sep 2026 20:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789070844; cv=none; b=rhDtSCK8PTJtrh8VB6jlL/o+fJsGcBBBD98C+Xx75NZbfnNiam6UJR5OPnfBjD75DAdeN57B2p6ubbVMCu0CIYAS47WisKoPZLwdwcxVZufkyOxURSZcVYL7bplHJ7paARRDbpBMZ2ViWyhT0Fo3Mx4in8xFcFrMHBcT8OeACN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789070844; c=relaxed/simple; bh=sXVKg4EbmRu7yPh3SaS0wsgWNPj96GEMOKxp/SBRHrE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S2hhEUdToejCMFpjscXpFYDMZ14VgnDv+0nHnQ5uVlHAk38TTem4jKsPm7rTG5Lq7Z7bn9KO2U7ymQxgluO28uYw36L7h/BYK+/gReMOdHbhDg8KGNdhHiYi1rbr0X1ScXIke5SCbYapWq8T9ipSDu+vlNNr785BkVeb63R9Kbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZVEVtb3F; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZVEVtb3F" Received: by mail-pj2-f12.google.com with SMTP id d9443c01a7336-2d747ee1f38so619885ad.2 for ; Thu, 10 Sep 2026 13:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789070843; x=1789675643; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/qnsVcp0ygYged1uz6VwSHb140QB2xftDP7LSuWB3m0=; b=ZVEVtb3FeNTwDm6fV4RdYelQuniTtHHMuKCBt3IxPKZNXVzG6Ldtes10sRNyz1Er94 9UzOjFindqwSCJwivwRPxwyopCPqSZP/LhIjczJEuJ/nzlR2CZphJnooo8gbtdb4/kRU 8N1Dto9eOKTsoFMvBEEcSlj6aTXrjwEzP4YxH9J7NPgxqN1lBFOEjiQ+Rrqw2Yjr9R+m mtfPMJeUFniAg4FJ1JzGtmFEIl2rly7PneL2tV/TaVI4B0JLFBnRJLcOFxdcuFmKah92 ymXm9WvZa/zD2Ly2YC1tqnX/RLVuIPR2LxhSkWFIKOCJpyayAA/MTa0WASxxx8qfbPxD T5WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789070843; x=1789675643; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/qnsVcp0ygYged1uz6VwSHb140QB2xftDP7LSuWB3m0=; b=TVR/1fxXjRRq7Y8pXKnFNKByrDXSaAQBpu19o0siDsDS7So2DpsDlnnGMlvCYJDn2E A/hULmmmBE4uwbXGKAFVRqZM0Vlvf8N8z52KFk0UAWWVZq7/Y1iUIQx1AYmZaggH8F3g IE2xZe7lEuJLTe+UtTi3NvGwbQtb0a//QWAhkrHgpIzc5iZDAzEOiLDGKtiYfzzqnNwm RFQmADvLuR6917CK/IXW571/k1S7OE6JNWz9sk/e7AToqQjO34FjyagzSn+2KmKRzo1U l5doEWKL2hJtzZekIUpnGwZl7t5ZKk4ffbz/+PbYJNX8h9Lr096vi50aA0nZh5zCSMng ujmg== X-Forwarded-Encrypted: i=1; AKwUvBwwYohY6XnRid8CoYDFQuxPDF/hTe2qNa+aoWNSqF5vZVVMDY6353g1vhQsc3S1ossnkNLeZyBAm1/R@vger.kernel.org X-Gm-Message-State: AFuF++kS3WqdTDQuCLc44UIL4viy4lqDONVJB+k5RjxC0ofFjWmtIfMZ Ax7N+VD5IEe9vYTk7jNpQI6YtXvHu8/aG4XmH03GDIKWZ6u2RFydCOoi X-Gm-Gg: AYBFou2UZNX2ig0bDKesyV4p5OMQkVdaER2dku4S54xpzVp0QPRs/RzpBqOswLxf909 yRtECMOMp1k4ShVKrj+KkQPDFPu3lJXKEG52PCJE/dMBDUfBy6dUTMnuCVKKAzMwuvn9xyF03jQ l4i8ESE9+Cs8qmofexgqzyVIcmiWY5QfFVWP/uD8kNVyorO3V1Idm3PYD31RksQj7csR/giu/CC j7dMXzY/nshdjVsVpXrHXhO3SfhFfJDK6kRZiyuiHTJWukinDcqG6KjhUOrSnAfcT/vSIxkEp20 VllE66vw6cUq8aZmSLZymkP8sj83GHKw/lm9TRF3l7vnQ47rf/RBjREehr01cfiNeQRRU+T58Qy Lc0BvZNQVbp8J29aUo2jCR10Mbw/3WbpUxBW4NUkrzM3pgvBbtdL9VshnrQGeEg8MWJx6Z1BB8n h8W8Y3oW/RZBEN/yW/hlEmFQmrscMsodulmPMBv8jij6D/k+c1Remp7OMpF/b9XEc9b1sSuL1wv W+D/z/VWLk1us+FeV25X1+B5wvDHJxBt50UzfKS8LHGz5Yj0U/gDT5V+vmehdqw0w== X-Received: by 2002:a17:902:ce10:b0:2db:3729:22de with SMTP id d9443c01a7336-2dd29e0ecddmr24004245ad.0.1789070842839; Thu, 10 Sep 2026 13:07:22 -0700 (PDT) Received: from [192.168.0.158] (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4f06423sm387884eec.20.2026.09.10.13.07.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2026 13:07:22 -0700 (PDT) Message-ID: <20057caf-aac9-4288-a82d-0f87fe1d3fc0@gmail.com> Date: Thu, 10 Sep 2026 13:07:21 -0700 Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/15] HID: hid-oxp: fix multicolor LED intensity scaling To: Andrei Aldea , Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Pavel Machek , linux-leds@vger.kernel.org References: <20260910032115.28669-1-andrei1998@gmail.com> <20260910032115.28669-6-andrei1998@gmail.com> Content-Language: en-US From: "Derek J. Clark" In-Reply-To: <20260910032115.28669-6-andrei1998@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/9/26 20:21, Andrei Aldea wrote: > The controller accepts eight-bit RGB components, but the sub-LED channel > maximum currently inherits the 0-100 overall brightness range. This > prevents userspace from selecting channel intensities above 100. > > Set each channel maximum to 255 and use the multicolor LED core helper to > scale components with the requested brightness. This also replaces the > private truncating calculation with the LED core's rounded calculation. > > Keep the existing Gen1 and Gen2 color packet layouts unchanged. > > Fixes: 84910c459d65 ("HID: hid-oxp: Add OneXPlayer configuration driver") > Assisted-by: LLM > Reviewed-by: Derek J. Clark > Signed-off-by: Andrei Aldea > --- > drivers/hid/hid-oxp.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/hid/hid-oxp.c b/drivers/hid/hid-oxp.c > index c3cfa95..bee1317 100644 > --- a/drivers/hid/hid-oxp.c > +++ b/drivers/hid/hid-oxp.c > @@ -1088,7 +1088,6 @@ static ssize_t oxp_rgb_status_show(void) > > static int oxp_rgb_color_set(void) > { > - u8 max_br = drvdata.led_mc->led_cdev.max_brightness; > u8 br = drvdata.led_mc->led_cdev.brightness; > u16 up = get_usage_page(drvdata.hdev); > u8 green, red, blue; > @@ -1096,9 +1095,10 @@ static int oxp_rgb_color_set(void) > u8 *data; > int i; > > - red = br * drvdata.led_mc->subled_info[0].intensity / max_br; > - green = br * drvdata.led_mc->subled_info[1].intensity / max_br; > - blue = br * drvdata.led_mc->subled_info[2].intensity / max_br; > + led_mc_calc_color_components(drvdata.led_mc, br); > + red = drvdata.led_mc->subled_info[0].brightness; > + green = drvdata.led_mc->subled_info[1].brightness; > + blue = drvdata.led_mc->subled_info[2].brightness; > > switch (up) { > case GEN1_USAGE_PAGE: > @@ -1383,16 +1383,19 @@ static struct mc_subled oxp_rgb_subled_info[] = { > { > .color_index = LED_COLOR_ID_RED, > .intensity = 0x24, > + .max_intensity = 0xff, > .channel = 0x1, > }, > { > .color_index = LED_COLOR_ID_GREEN, > .intensity = 0x22, > + .max_intensity = 0xff, > .channel = 0x2, > }, > { > .color_index = LED_COLOR_ID_BLUE, > .intensity = 0x99, > + .max_intensity = 0xff, > .channel = 0x3, > }, > }; Tested-by: Derek J. Clark Reviewed-by: Derek J. Clark