From: Matthew Wilcox <matthew@wil.cx>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: dax@gurulabs.com, erich@areca.com.tw, akpm@osdl.org,
arjan@infradead.org, oliver@neukum.org, rlrevell@joe-job.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] Areca RAID driver (arcmsr) cleanups
Date: Mon, 2 Jan 2006 10:04:47 -0700 [thread overview]
Message-ID: <20060102170447.GG19769@parisc-linux.org> (raw)
In-Reply-To: <20051230212158.4b97edfe.rdunlap@xenotime.net>
On Fri, Dec 30, 2005 at 09:21:58PM -0800, Randy.Dunlap wrote:
> /*
> -**********************************************************************************
> -**********************************************************************************
> +***************************************************************************
> +***************************************************************************
> */
I'd be inclined to remove these useless comment blocks altogether ...
> - /* allocate scsi host information (includes out adapter) scsi_host_alloc==scsi_register */
> + /* allocate scsi host information (includes our adapter)
> + * scsi_host_alloc==scsi_register */
> if ((host =
> scsi_host_alloc(&arcmsr_scsi_host_template,
> sizeof(struct ACB))) == 0) {
host = scsi_host_alloc(...)
if (!host) { ...
> ************************************************************
> - ** We do not allow muti ioctls to the driver at the same duration.
> + ** We do not allow multi ioctls to the driver at the same duration.
s/duration/time/. And how do they prevent that?
next prev parent reply other threads:[~2006-01-02 17:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-22 5:20 ETA for Areca RAID driver (arcmsr) in mainline? Dax Kelson
2005-12-22 5:34 ` Lee Revell
2005-12-22 6:26 ` Dax Kelson
2005-12-22 7:04 ` Lee Revell
2005-12-22 7:24 ` Dax Kelson
2005-12-22 8:17 ` Oliver Neukum
2005-12-22 8:20 ` Arjan van de Ven
2005-12-22 13:24 ` Andrew Morton
2005-12-22 19:31 ` Dax Kelson
2005-12-30 19:32 ` Randy.Dunlap
2005-12-31 5:21 ` [PATCH 2/2] Areca RAID driver (arcmsr) cleanups Randy.Dunlap
2006-01-02 17:04 ` Matthew Wilcox [this message]
2006-01-04 9:18 ` ETA for Areca RAID driver (arcmsr) in mainline? Andrew Morton
2006-01-07 5:17 ` [PATCH] Areca RAID driver (arcmsr) cleanups Randy.Dunlap
2005-12-22 6:43 ` ETA for Areca RAID driver (arcmsr) in mainline? Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060102170447.GG19769@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=dax@gurulabs.com \
--cc=erich@areca.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=rdunlap@xenotime.net \
--cc=rlrevell@joe-job.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.