All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Dirk Behme <dirk.behme@de.bosch.com>
Cc: 'Linux OMAP Open Source' <linux-omap-open-source@linux.omap.com>
Subject: Re: Problem on mounting a jffs2 rootfs image
Date: Mon, 2 Jan 2006 10:31:08 -0800	[thread overview]
Message-ID: <20060102183107.GH6034@atomide.com> (raw)
In-Reply-To: <4374F44A.7080807@de.bosch.com>

* Dirk Behme <dirk.behme@de.bosch.com> [051111 11:43]:
> Tony Lindgren wrote:
> >>Do you checked the thread "JFFS2 problem on OSK"
> >>
> >>http://linux.omap.com/pipermail/linux-omap-open-source/2005-July/004717.html
> >>
> >>?
> >
> >I wonder if there's any way to test for the OSK version? Then we could
> >check the timings.
> 
> Are there any OSKs out there which need different *CS3* timings? If not, 
> we only have to check for correct timings, something like:
> 
> --- ./arch/arm/mach-omap/omap1/board-osk.c_orig 2005-11-11 
> 20:22:40.628440008 +0100
> +++ ./arch/arm/mach-omap/omap1/board-osk.c      2005-11-11 
> 20:31:51.056762184 +0100
> @@ -192,8 +192,18 @@ static struct omap_board_config_kernel o
>         { OMAP_TAG_USB,           &osk_usb_config },
>  };
> 
> +#define EMFIS_CS3_VAL (0x30003361)
> +
>  static void __init osk_init(void)
>  {
> +        /* Workaround for wrong CS3 (NOR flash) timing
> +         * There are some U-Boot versions out there which configure
> +         * wrong CS3 memory timings. This mainly leads to CRC
> +         * or similiar errors if you use NOR flash (e.g. with JFFS2)
> +         */
> +        if(omap_readl(EMIFS_CS3_CONFIG) != EMFIS_CS3_VAL)
> +               omap_writel(EMFIS_CS3_VAL, EMIFS_CS3_CONFIG);
> +
>         osk_flash_resource.end = osk_flash_resource.start = 
> omap_cs3_phys();
>         osk_flash_resource.end += SZ_32M - 1;
>         platform_add_devices(osk5912_devices, ARRAY_SIZE(osk5912_devices));
> 
> 0x30003361 is the value used by spectrum digital. Seems to work. But I 
> don't think it's the fastest possible timing. Anybody with a better CS3 
> timing?

I think we should push this to avoid postings on JFFS2 problems. How
about changing the patch to use the EMIFS_CCS macro instead?

Regards,

Tony

       reply	other threads:[~2006-01-02 18:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <43741c56.6400405c.6f4c.ffff87c0@mx.gmail.com>
     [not found] ` <43743DC9.1090702@de.bosch.com>
     [not found]   ` <20051111173755.GC10822@atomide.com>
     [not found]     ` <4374F44A.7080807@de.bosch.com>
2006-01-02 18:31       ` Tony Lindgren [this message]
2006-01-02 20:35         ` Problem on mounting a jffs2 rootfs image Dirk Behme
2006-01-02 22:10           ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060102183107.GH6034@atomide.com \
    --to=tony@atomide.com \
    --cc=dirk.behme@de.bosch.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.