All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
	linux-usb-devel@lists.sourceforge.net, zaitcev@redhat.com
Subject: Re: usb: replace __setup("nousb") with __module_param_call
Date: Mon, 2 Jan 2006 23:07:14 -0800	[thread overview]
Message-ID: <20060102230714.3aa4f85b.zaitcev@redhat.com> (raw)
In-Reply-To: <200601030147.46504.dtor_core@ameritech.net>

On Tue, 3 Jan 2006 01:47:46 -0500, Dmitry Torokhov <dtor_core@ameritech.net> wrote:

> +static int __init obsolete_checksetup(char *line, int len)
> -		int n = strlen(p->str);
> -		if (!strncmp(line, p->str, n)) {
> +		if (!strncmp(line, p->str, len) && len == strlen(p->str)) {

This looks like it should work, with the disclaimer that I am not
infallible.

But even if it does, my patch saved reading, so I think it should be
applied as well.

-- Pete

  reply	other threads:[~2006-01-03  7:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-20 22:15 usb: replace __setup("nousb") with __module_param_call Pete Zaitcev
2005-12-22  6:10 ` Dmitry Torokhov
2005-12-22  8:24   ` Pete Zaitcev
2006-01-03  6:47     ` Dmitry Torokhov
2006-01-03  7:07       ` Pete Zaitcev [this message]
2006-01-03 14:46         ` Dmitry Torokhov
2006-01-03 19:35           ` Pete Zaitcev
2006-01-03 20:34             ` [linux-usb-devel] " Alan Stern
2006-01-03 20:38               ` Dmitry Torokhov
2006-01-03 20:52                 ` Alan Stern
2006-01-03 21:04                   ` Dmitry Torokhov
2006-01-03 20:44               ` Pete Zaitcev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060102230714.3aa4f85b.zaitcev@redhat.com \
    --to=zaitcev@redhat.com \
    --cc=dtor_core@ameritech.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.