Re: Patch for ipt_time (to enable start > stop / crossing midnight)

[Heiko Schlittermann <hs@schlittermann.de>]

[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]

Hello Krzysztof & *,

Krzysztof Oledzki <olenf@ans.pl> (Mi 04 Jan 2006 16:47:43 CET):
> 
> How about this (also attached) one? Untested, but should work.
> [NETFILTER] Support for timestart > timestop in ipt_time (eg. 21:00 - 15:00)
> 
> Based on a patch from Heiko Schlittermann <hs@schlittermann.de>

My "compound return" looked shorter :) but I admit, that your's is
better readable.  I don't know, which one is faster or if good gcc
optimimzes both the same way ...  (I learned to save every bit ;-)

> -	if ((packet_time < info->time_start) || (packet_time > info->time_stop))
> -		return 0;
> +	if (info->time_start < info->time_stop) {
> +		if ((packet_time < info->time_start) || (packet_time > info->time_stop))
> +			return 0;
> +	} else {
> +		if ((packet_time < info->time_start) && (packet_time > info->time_stop))
> +			return 0;
> +	}


But I'd like to see:

	if (info->time_start < info->time_stop) {
		if ((packet_time < info->time_start) || (packet_time >= info->time_stop))
			return 0;
	} else {
		if ((packet_time < info->time_start) && (packet_time >= info->time_stop))
			return 0;
	}

    
To match --timestart 12:07 --timestop 13:10 really from 12:07:00 to 13:09:59.



    Best regards from Dresden
    Viele Grüße aus Dresden
    Heiko Schlittermann
-- 
 SCHLITTERMANN.de ---------------------------- internet & unix support -
 Heiko Schlittermann HS12-RIPE -----------------------------------------
 gnupg encrypted messages are welcome - key ID: 48D0359B ---------------
 gnupg fingerprint: 3061 CFBF 2D88 F034 E8D2  7E92 EE4E AC98 48D0 359B -

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]