From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] mm: Clean up local variables
Date: Wed, 04 Jan 2006 17:18:19 +0000 [thread overview]
Message-ID: <20060104171819.GO19769@parisc-linux.org> (raw)
In-Reply-To: <20060104170119.GB1243@neon.tklauser.home>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On Wed, Jan 04, 2006 at 06:01:19PM +0100, Tobias Klauser wrote:
> diff -urpN -X dontdiff linux-2.6.15/mm/slab.c linux-2.6.15~tk/mm/slab.c
> --- linux-2.6.15/mm/slab.c 2006-01-03 14:41:57.000000000 +0100
> +++ linux-2.6.15~tk/mm/slab.c 2006-01-04 15:52:41.000000000 +0100
> @@ -921,7 +921,6 @@ static int __devinit cpuup_callback(stru
> down(&cache_chain_sem);
>
> list_for_each_entry(cachep, &cache_chain, next) {
> - struct array_cache *nc;
> cpumask_t mask;
>
> mask = node_to_cpumask(node);
While this does work, it's quite bad style. Much better to move the
upper level declaration (line 856) into the block it's used in (line
893). BTW, that function is too big at 133 lines and should be split.
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-01-04 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-04 17:01 [KJ] [PATCH] mm: Clean up local variables Tobias Klauser
2006-01-04 17:14 ` Jesper Juhl
2006-01-04 17:18 ` Matthew Wilcox [this message]
2006-01-04 22:39 ` Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060104171819.GO19769@parisc-linux.org \
--to=matthew@wil.cx \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.