All of lore.kernel.org
 help / color / mirror / Atom feed
* [KJ] [PATCH 2/2] Remove LINUX_VERSION_CODE check in pwc/pwc-if.c
@ 2006-01-04 17:12 Eric Sesterhenn / snakebyte
  2006-01-04 17:26 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Sesterhenn / snakebyte @ 2006-01-04 17:12 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

hi,

this patch removes the LINUX_VERSION check in
drivers/usb/media/pwc/pwc-if.c

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

--- linux-2.6.15-eric/drivers/usb/media/pwc/pwc-if.c.orig	2006-01-04 18:03:17.000000000 +0100
+++ linux-2.6.15-eric/drivers/usb/media/pwc/pwc-if.c	2006-01-04 18:03:44.000000000 +0100
@@ -827,13 +827,10 @@ static int pwc_isoc_init(struct pwc_devi
 	/* Get the current alternate interface, adjust packet size */
 	if (!udev->actconfig)
 		return -EFAULT;
-#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,5)
-	idesc = &udev->actconfig->interface[0]->altsetting[pdev->valternate];
-#else
+
 	intf = usb_ifnum_to_if(udev, 0);
 	if (intf)
 		idesc = usb_altnum_to_altsetting(intf, pdev->valternate);
-#endif
 		
 	if (!idesc)
 		return -EFAULT;



[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [KJ] [PATCH 2/2] Remove LINUX_VERSION_CODE check in pwc/pwc-if.c
  2006-01-04 17:12 [KJ] [PATCH 2/2] Remove LINUX_VERSION_CODE check in pwc/pwc-if.c Eric Sesterhenn / snakebyte
@ 2006-01-04 17:26 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2006-01-04 17:26 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

On Wed, Jan 04, 2006 at 06:12:30PM +0100, Eric Sesterhenn / snakebyte wrote:
> hi,
> 
> this patch removes the LINUX_VERSION check in
> drivers/usb/media/pwc/pwc-if.c
> 
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

How about redoing this and take out the #include <linux/version.h> at
the same time, as it should no longer be needed?

And do the same thing for the pwc-ctrl.c file perhaps?

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-01-04 17:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-04 17:12 [KJ] [PATCH 2/2] Remove LINUX_VERSION_CODE check in pwc/pwc-if.c Eric Sesterhenn / snakebyte
2006-01-04 17:26 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.