From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Denis Vlasenko <vda@ilport.com.ua>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix warning in 8250.c
Date: Wed, 4 Jan 2006 18:14:25 +0000 [thread overview]
Message-ID: <20060104181425.GE3119@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200601031012.49068.vda@ilport.com.ua>
On Tue, Jan 03, 2006 at 10:12:48AM +0200, Denis Vlasenko wrote:
> CC drivers/serial/8250.o
> /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/serial/8250.c:1085: warning: 'transmit_chars' declared inline after being called
> /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/serial/8250.c:1085: warning: previous declaration of 'transmit_chars' was here
>
> Since this function is not small, inlining effect is way below noise floor.
> Let's just remove _INLINE_.
I think we want to remove _INLINE_ from both receive_chars and
transmit_chars. Both functions aren't small, so...
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-01-04 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-03 8:12 [PATCH] fix warning in 8250.c Denis Vlasenko
2006-01-04 18:14 ` Russell King [this message]
2006-01-04 18:18 ` Christoph Hellwig
2006-01-04 19:12 ` Russell King
2006-01-04 23:51 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060104181425.GE3119@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.