From: Greg KH <greg@kroah.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: J?rn Engel <joern@wohnheim.fh-wedel.de>,
linux-kernel@vger.kernel.org, Stefan Rompf <stefan@loplof.de>,
Clemens Fruhwirth <clemens@endorphin.org>,
stable@kernel.org, Arjan van de Ven <arjan@infradead.org>
Subject: Re: [stable] Re: [Patch 2.6] dm-crypt: zero key before freeing it
Date: Wed, 4 Jan 2006 13:15:26 -0800 [thread overview]
Message-ID: <20060104211526.GA12042@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0601041242270.19134@shark.he.net>
On Wed, Jan 04, 2006 at 12:43:21PM -0800, Randy.Dunlap wrote:
> On Wed, 4 Jan 2006, J?rn Engel wrote:
>
> > On Wed, 4 January 2006 12:28:59 -0800, Randy.Dunlap wrote:
> > > On Wed, 4 Jan 2006, Stefan Rompf wrote:
> > > > Am Mittwoch 04 Januar 2006 21:09 schrieb Arjan van de Ven:
> > > >
> > > > > since a memset right before a free is a very unusual code pattern in the
> > > > > kernel it may well be worth putting a short comment around it to prevent
> > > > > someone later removing it as "optimization"
> > > >
> > > > Valid objection, here is an update (and see, I'm running 2.6.15 now ;-)
> > >
> > > A reason "why" would be more helpful that a "what".
> >
> > "prevent information leak"
> >
> > This is still a "what", but at least not a "how".
>
> OK, that's a much better changelog entry or source code comment...
> if it could be put in one of those places.
Yes, Stefan, care to redo this with an updated changelog command?
thanks,
greg k-h
next prev parent reply other threads:[~2006-01-04 21:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-04 20:08 [Patch 2.6] dm-crypt: zero key before freeing it Stefan Rompf
2006-01-04 20:09 ` Arjan van de Ven
2006-01-04 20:26 ` Stefan Rompf
2006-01-04 20:28 ` Randy.Dunlap
2006-01-04 20:41 ` Jörn Engel
2006-01-04 20:43 ` Randy.Dunlap
2006-01-04 21:15 ` Greg KH [this message]
2006-01-04 21:44 ` [Patch 2.6] dm-crypt: Zero key material before free to avoid information leak Stefan Rompf
2006-01-24 4:49 ` [Patch 2.6] dm-crypt: zero key before freeing it Neil Brown
2006-01-24 21:29 ` Stefan Rompf
2006-01-24 21:44 ` Neil Brown
2006-01-24 23:03 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060104211526.GA12042@kroah.com \
--to=greg@kroah.com \
--cc=arjan@infradead.org \
--cc=clemens@endorphin.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=stable@kernel.org \
--cc=stefan@loplof.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.