All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] hwmon-pc87360-use-sensor-attr-arrays.patch
Date: Wed, 04 Jan 2006 21:12:11 +0000	[thread overview]
Message-ID: <20060104221211.5f39cfd0.khali@linux-fr.org> (raw)

Hi Jim,

> I couldnt get rc5-mm3 to boot properly (some switchroot prob)
> so I baselined this patch against rc7 + all accepted patches named in
> http://khali.linux-fr.org/devel/i2c/linux-2.6/series
> 
> (diffstat is uninteresting, but hey ..)
> jimc at harpo i2c-stuff]$ diffstat hwmon-pc87360-use-sensor-attr-arrays.patch
>  pc87360.c |  410 
> ++++++++++++++++++++++++++++++--------------------------------
>  1 files changed, 202 insertions(+), 208 deletions(-)

It's not that uninteresting. It shows that the patch doesn't only
shrink the binary size, it also kills a few lines of source code. Not
much, but at least it doesn't *add* lines of code, which is a good
thing.

> Convert individual sensors to sensor-attr arrays by each sensor type,
> and initialize them in loops instead of long blocks of individual calls.

Looks good (except for some trailing whitespace which I had to remove,
grmbl), applied, thanks.

It's probably one of the last large non-bug-fixing patches I accept for
Linux 2.6.16.

-- 
Jean Delvare


             reply	other threads:[~2006-01-04 21:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-04 21:12 Jean Delvare [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-12-28 18:51 [lm-sensors] hwmon-pc87360-use-sensor-attr-arrays.patch Jim Cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060104221211.5f39cfd0.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.