All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Dave Jones <davej@redhat.com>,
	linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: Make apm buildable without legacy pm.
Date: Thu, 5 Jan 2006 18:22:01 +0100	[thread overview]
Message-ID: <20060105172201.GC3831@stusta.de> (raw)
In-Reply-To: <20060105014126.GH5895@kurtwerks.com>

On Wed, Jan 04, 2006 at 08:41:26PM -0500, Kurt Wall wrote:
> On Tue, Jan 03, 2006 at 09:33:52AM -0500, Dave Jones took 0 lines to write:
> > APM doesn't _need_ the PM_LEGACY junk, so remove it's dependancy
> > from Kconfig, and ifdef the junk in the code.
> > Whilst the ifdefs are ugly, when the legacy stuff gets ripped out
> > so will the ifdefs.
> > 
> > Signed-off-by: Dave Jones <davej@redhat.com>
> > 
> > --- linux-2.6.14/arch/i386/Kconfig~	2005-12-22 22:06:10.000000000 -0500
> > +++ linux-2.6.14/arch/i386/Kconfig	2005-12-22 22:06:16.000000000 -0500
> > @@ -710,7 +710,7 @@ depends on PM && !X86_VISWS
> >  
> >  config APM
> >  	tristate "APM (Advanced Power Management) BIOS support"
> > -	depends on PM && PM_LEGACY
> > +	depends on PM
> >  	---help---
> >  	  APM is a BIOS specification for saving power using several different
> >  	  techniques. This is mostly useful for battery powered laptops with
> 
> Here's this hunk re-diffed against 2.6.15 (which applies without
> needing patch to apply an offset of -11 lines):
>...

Offsets when applying patches are usually completely harmless (problems 
are only possible if there isn't enough context, but that's obviously 
not the case here).

> Kurt

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      reply	other threads:[~2006-01-05 17:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-03 14:33 Make apm buildable without legacy pm Dave Jones
2006-01-05  1:41 ` Kurt Wall
2006-01-05 17:22   ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060105172201.GC3831@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.