From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: isdn4linux@listserv.isdn4linux.de,
Armin Schindler <armin@melware.de>,
linux-kernel@vger.kernel.org, kkeil@suse.de,
kai.germaschewski@gmx.de
Subject: [2.6 patch] drivers/isdn/hardware/eicon/os_4bri.c: correct the xdiLoadFile() signature
Date: Thu, 5 Jan 2006 19:18:37 +0100 [thread overview]
Message-ID: <20060105181837.GF12313@stusta.de> (raw)
It's not good if caller and callee disagree regarding the type of the
arguments.
In this case, this could cause problems on 64bit architectures.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Armin Schindler <armin@melware.de>
--- linux-2.6.15-rc1-mm2-full/drivers/isdn/hardware/eicon/os_4bri.c.old 2005-11-19 03:48:37.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/isdn/hardware/eicon/os_4bri.c 2005-11-19 06:18:16.000000000 +0100
@@ -16,6 +16,7 @@
#include "diva_pci.h"
#include "mi_pc.h"
#include "dsrv4bri.h"
+#include "helpers.h"
static void *diva_xdiLoadFileFile = NULL;
static dword diva_xdiLoadFileLength = 0;
@@ -815,7 +816,7 @@
return (ret);
}
-void *xdiLoadFile(char *FileName, unsigned long *FileLength,
+void *xdiLoadFile(char *FileName, dword *FileLength,
unsigned long lim)
{
void *ret = diva_xdiLoadFileFile;
next reply other threads:[~2006-01-05 18:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-05 18:18 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-19 7:58 [2.6 patch] drivers/isdn/hardware/eicon/os_4bri.c: correct the xdiLoadFile() signature Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060105181837.GF12313@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=armin@melware.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.