From: Dave Jones <davej@redhat.com>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: dual line backtraces for i386.
Date: Thu, 5 Jan 2006 16:28:02 -0500 [thread overview]
Message-ID: <20060105212802.GR20809@redhat.com> (raw)
In-Reply-To: <200601051321_MC3-1-B55B-8147@compuserve.com>
On Thu, Jan 05, 2006 at 01:18:32PM -0500, Chuck Ebbert wrote:
> > - printk("\n");
> > + if (space == 0) {
> > + printk(" ");
> > + space = 1;
> > + } else {
> > + printk("\n");
> > + space = 0;
> > + }
>
> Why not:
>
> printk(space == 0 ? " " : "\n");
> space = !space;
readability ?
Personally, I despise the ternary operator, because it makes me
stop to try to parse it every time I see it. With the code I wrote
it's blindlingly obvious what is going on.
Dave
next prev parent reply other threads:[~2006-01-06 2:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-05 18:18 dual line backtraces for i386 Chuck Ebbert
2006-01-05 21:28 ` Dave Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-06 18:36 Chuck Ebbert
2006-01-06 19:17 ` Jan Engelhardt
2006-01-06 19:33 ` Bob Copeland
2006-01-07 0:00 ` Mitchell Blank Jr
2006-01-07 11:16 ` Jan Engelhardt
2006-01-05 6:22 Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060105212802.GR20809@redhat.com \
--to=davej@redhat.com \
--cc=76306.1226@compuserve.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.