From: Timo Hirvonen <tihirvon@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove gfp argument from kstrdup()
Date: Fri, 6 Jan 2006 14:15:09 +0200 [thread overview]
Message-ID: <20060106141509.01c66bf2.tihirvon@gmail.com> (raw)
In-Reply-To: <84144f020601060351g48f3ef5bqf25a2a1bf02af4e6@mail.gmail.com>
On Fri, 6 Jan 2006 13:51:41 +0200
Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> On 1/5/06, Timo Hirvonen <tihirvon@gmail.com> wrote:
> > All kstrdup() callers use GFP_KERNEL flag so this parameter seems to be
> > useless.
>
> Please don't. You're making the API inconsistent and forcing everyone
> to use GFP_KERNEL for little or no benefit.
I don't see why any other GFP_* flag could be useful for strings.
--
http://onion.dynserv.net/~timo/
next prev parent reply other threads:[~2006-01-06 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-05 21:42 [PATCH] Remove gfp argument from kstrdup() Timo Hirvonen
2006-01-06 11:51 ` Pekka Enberg
2006-01-06 12:15 ` Timo Hirvonen [this message]
2006-01-06 12:20 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060106141509.01c66bf2.tihirvon@gmail.com \
--to=tihirvon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.