All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Carlos Manuel Duclos Vergara <carlos@embedded.cl>
Cc: kernel-janitors@lists.osdl.org, Kees Cook <kees@outflux.net>,
	linux-kernel@vger.kernel.org
Subject: Re: MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_*
Date: Sun, 08 Jan 2006 21:58:00 +0000	[thread overview]
Message-ID: <20060108215800.GA31398@kroah.com> (raw)
In-Reply-To: <200601081855.17723.carlos@embedded.cl>

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

On Sun, Jan 08, 2006 at 06:55:16PM -0300, Carlos Manuel Duclos Vergara wrote:
> Hi everyone,
> 
> I have two ideas about what to do with MODULE_VERSION:
> 1.- Defining MODULE_VERSION = KERNEL_VERSION

No.

> 2.- Schedule it for removal in one or two more versions, and automagically use 
> the KERNEL_VERSION as module's version.

No, just let the authors of the different drivers that want to use
MODULE_VERSION use it (for some people it does matter, and they keep it
up to date.)  Everyone else, just don't add it if you don't care about
it.

> Any comments?

In short, leave it alone :)

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Carlos Manuel Duclos Vergara <carlos@embedded.cl>
Cc: kernel-janitors@lists.osdl.org, Kees Cook <kees@outflux.net>,
	linux-kernel@vger.kernel.org
Subject: Re: MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* stuffs)
Date: Sun, 8 Jan 2006 13:58:00 -0800	[thread overview]
Message-ID: <20060108215800.GA31398@kroah.com> (raw)
In-Reply-To: <200601081855.17723.carlos@embedded.cl>

On Sun, Jan 08, 2006 at 06:55:16PM -0300, Carlos Manuel Duclos Vergara wrote:
> Hi everyone,
> 
> I have two ideas about what to do with MODULE_VERSION:
> 1.- Defining MODULE_VERSION = KERNEL_VERSION

No.

> 2.- Schedule it for removal in one or two more versions, and automagically use 
> the KERNEL_VERSION as module's version.

No, just let the authors of the different drivers that want to use
MODULE_VERSION use it (for some people it does matter, and they keep it
up to date.)  Everyone else, just don't add it if you don't care about
it.

> Any comments?

In short, leave it alone :)

thanks,

greg k-h

  reply	other threads:[~2006-01-08 21:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-30  0:04 [KJ] adding missing MODULE_* stuffs Kees Cook
2006-01-04  1:13 ` Greg KH
2006-01-04  5:18 ` Kees Cook
2006-01-04  5:43 ` Greg KH
2006-01-08 20:45 ` MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* stuffs) Alexey Dobriyan
2006-01-08 20:45   ` Alexey Dobriyan
2006-01-08 21:55   ` MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* Carlos Manuel Duclos Vergara
2006-01-08 21:55     ` MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* stuffs) Carlos Manuel Duclos Vergara
2006-01-08 21:58     ` Greg KH [this message]
2006-01-08 21:58       ` Greg KH
2006-01-08 22:32       ` MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* Matt Domsch
2006-01-08 22:32         ` MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* stuffs) Matt Domsch
2006-01-08 22:33         ` MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* Matt Domsch
2006-01-08 22:33           ` MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* stuffs) Matt Domsch
2006-01-08 22:03     ` MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* Matthew Wilcox
2006-01-08 22:03       ` MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* stuffs) Matthew Wilcox
2006-01-08 23:41     ` MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* Håkon Løvdal
2006-01-08 23:41       ` MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* stuffs) Håkon Løvdal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060108215800.GA31398@kroah.com \
    --to=greg@kroah.com \
    --cc=carlos@embedded.cl \
    --cc=kees@outflux.net \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.