All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] linux-2.6.15-rc7/drivers/pci/syscall.c
Date: Mon, 09 Jan 2006 19:12:01 +0000	[thread overview]
Message-ID: <20060109191201.GA22772@kroah.com> (raw)
In-Reply-To: <200601091138.03704.cneira@srb.cl>

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

On Mon, Jan 09, 2006 at 08:02:19PM +0100, Jesper Juhl wrote:
> On 1/9/06, Greg KH <greg@kroah.com> wrote:
> > On Mon, Jan 09, 2006 at 11:38:03AM +0000, carlos neira wrote:
> > > Greetings :
> > >
> > > patch :linux-2.6.15-rc7/drivers/pci/syscall.c
> > >
> > > replaced a  lock_kernel with spinlocks  , compile tested ok
> >
> > What arch did you compile this for?
> >
> > And why remove the lock_kernel calls here, are they hurting anything?
> >
> I can't comment on the specific patch, but in general I thought we
> wanted to get rid of lock_kernel() / unlock_kernel() over time?  If
> that is indeed the case, then patches like this one are a step in the
> right direction - no?

"over time, if it makes sense to do so."  

For this specific example, the code should be converted to the kthread
api, which would remove these instances.

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2006-01-09 19:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-09 11:38 [KJ] linux-2.6.15-rc7/drivers/pci/syscall.c carlos neira
2006-01-09 15:13 ` Matthew Wilcox
2006-01-09 17:07 ` Greg KH
2006-01-09 19:02 ` Jesper Juhl
2006-01-09 19:12 ` Greg KH [this message]
2006-01-09 19:29 ` Matthew Wilcox
2006-01-09 19:47 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060109191201.GA22772@kroah.com \
    --to=greg@kroah.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.